Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KEYBOARD_SHARED_EP on ChibiOS #7860

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Fix KEYBOARD_SHARED_EP on ChibiOS #7860

merged 1 commit into from
Jan 12, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 10, 2020 •
edited
Loading

Description

Currently produces the error:

Compiling: tmk_core/protocol/chibios/usb_main.c                                                    tmk_core/protocol/chibios/usb_main.c:386:16: error: 'set_led_transfer_cb' defined but not used [-Werror=unused-function]
 static void    set_led_transfer_cb(USBDriver *usbp) {
                ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
 [ERRORS]

This PR aligns checks to callsite:

qmk_firmware/tmk_core/protocol/chibios/usb_main.c

Lines 448 to 453 in 2d051d8

#if defined(SHARED_EP_ENABLE) && !defined(KEYBOARD_SHARED_EP)
case SHARED_INTERFACE:
usbSetupTransfer(usbp, set_report_buf, sizeof(set_report_buf), set_led_transfer_cb);
return TRUE;
break;
#endif

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Jan 10, 2020
@zvecr zvecr requested a review from a team January 10, 2020 20:41
@fauxpark
Copy link
Member

This change makes it compile, but now the caps lock LED is broken. I think this may be a similar issue to #4824 (I only fixed it for LUFA as I didn't have any Arm chips at the time; now I have a Proton C I can test).

@zvecr
Copy link
Member Author

zvecr commented Jan 12, 2020

@fauxpark can we merge this as is, and fix in another PR? This PR doesnt make the current situation any worse, and I have more stuff dependent on this so would like to see in in soonish.

@drashna drashna requested a review from a team January 12, 2020 19:02
@fauxpark
Copy link
Member

Yeah, that's fine. I'll see if I can port my fix for LUFA over.

@fauxpark fauxpark merged commit ff5742d into qmk:master Jan 12, 2020
@fauxpark fauxpark mentioned this pull request Jan 12, 2020
Merged
13 tasks
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 12, 2020
@zvecr @drashna
Fix KEYBOARD_SHARED_EP on ChibiOS (qmk#7860)
ce5a946
@drashna drashna mentioned this pull request Feb 12, 2020
Merged
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 14, 2020
@zvecr @fdidron
Fix KEYBOARD_SHARED_EP on ChibiOS (qmk#7860)
cf45fed
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@zvecr @HokieGeek
Fix KEYBOARD_SHARED_EP on ChibiOS (qmk#7860)
eaee6a6
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 26, 2020
@zvecr @fdidron
Fix KEYBOARD_SHARED_EP on ChibiOS (qmk#7860)
532cf85
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@zvecr @kujawakk
Fix KEYBOARD_SHARED_EP on ChibiOS (qmk#7860)
a2e8357
@zvecr zvecr deleted the feature/KEYBOARD_SHARED_EP_chibios branch April 28, 2020 01:12
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr @fauxpark
Fix KEYBOARD_SHARED_EP on ChibiOS (qmk#7860)
d754ea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @fauxpark @drashna