Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDB 60: Configurator bugfix #7851

Merged
merged 3 commits into from
Jan 12, 2020
Merged

IDB 60: Configurator bugfix #7851

merged 3 commits into from
Jan 12, 2020

Conversation

noroadsleft
Copy link
Member

Description

#7798 had a bad info.json, and the way it was messed up made it hard for me to debug, so I merged it anyway to get a clean state and not delay @itspngu's PR any longer.

Also a minor readme change because I noticed it when I was using the readme for a reference.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Issues Fixed or Closed by This PR

http://api.qmk.fm/v1/keyboards/error_log:

{
  "severity": "error",
  "message": "Error: Uncaught exception while processing keyboard idb/idb_60! KeyError: 'layout'"
},

Fixes to:

LAYOUT_all:
image

LAYOUT_default:
image

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team January 10, 2020 09:34
@zvecr zvecr requested a review from a team January 11, 2020 23:18
@drashna drashna merged commit 9bbce7a into qmk:master Jan 12, 2020
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jan 12, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (71 commits)
  [Keyboard] Reviung41: Configurator layout support (qmk#7852)
  [Keyboard] IDB 60: Configurator bugfix (qmk#7851)
  [Keyboard] Add Xiaomi MK02 (qmk#7825)
  Add user keymaps for KBD67MKII/Lily58 (qmk#7671)
  [Keyboard] KPRepublic BM60 RGB (qmk#7842)
  Add Lily58 serial to LIB_SRC to avoid LTO issue (qmk#7868)
  Adi's DZ65RGB layout (qmk#7845)
  yapf and style
  Make the udev rules easier to read and manage
  Fix Pro Micro's and its bootloader's name
  CLI: Rework ModemManager check and add udev check
  [Keyboard] NK65 Refactor (qmk#7862)
  [Keymap] Updated keymaps (qmk#7834)
  [Keymap] Add additional dynamic macro key to dshields keymaps. (qmk#7853)
  added ymdk ymd09 keyboard (qmk#7831)
  [Keymap] Update my iris keymap for LTO and rgbled split (qmk#7849)
  [Keyboard] Changes to support latest release of VIA, moved files to "idb" folder in "keymaps" in preparation of adding more boards, made changes to LAYOUT_ macros (qmk#7798)
  Fix a couple of USB VIDs for the API (qmk#7848)
  Add per-key IGNORE_MOD_TAP_INTERRUPT feature (qmk#7838)
  Refactor f103,f072,f042 based keyboards to use new MCU selection defaults (qmk#7705)
  ...
@noroadsleft noroadsleft deleted the cf/idb_60 branch January 15, 2020 01:09
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* info.json: use debug linting

Changes the white space, mostly.

* info.json: correct file structure

* readme.md: templating
@noroadsleft noroadsleft removed the configurator affects configurator label Mar 2, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* info.json: use debug linting

Changes the white space, mostly.

* info.json: correct file structure

* readme.md: templating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants