-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Keyboard: KPRepublic BM60 RGB #7842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since KPRepublic seems to call this just "BM60 RGB," I'd prefer if the folder was bm60rgb
instead of including the hs
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
I've renamed the directory and associated files to bm60rgb. |
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
Do we want to put this in a |
ooof that's an old PR. I think we should just merge this in for the time being. That PR has merge conflicts, so it can be moved as part of the merge conflict resolution. |
Thanks! |
* 'master' of https://github.com/qmk/qmk_firmware: (71 commits) [Keyboard] Reviung41: Configurator layout support (qmk#7852) [Keyboard] IDB 60: Configurator bugfix (qmk#7851) [Keyboard] Add Xiaomi MK02 (qmk#7825) Add user keymaps for KBD67MKII/Lily58 (qmk#7671) [Keyboard] KPRepublic BM60 RGB (qmk#7842) Add Lily58 serial to LIB_SRC to avoid LTO issue (qmk#7868) Adi's DZ65RGB layout (qmk#7845) yapf and style Make the udev rules easier to read and manage Fix Pro Micro's and its bootloader's name CLI: Rework ModemManager check and add udev check [Keyboard] NK65 Refactor (qmk#7862) [Keymap] Updated keymaps (qmk#7834) [Keymap] Add additional dynamic macro key to dshields keymaps. (qmk#7853) added ymdk ymd09 keyboard (qmk#7831) [Keymap] Update my iris keymap for LTO and rgbled split (qmk#7849) [Keyboard] Changes to support latest release of VIA, moved files to "idb" folder in "keymaps" in preparation of adding more boards, made changes to LAYOUT_ macros (qmk#7798) Fix a couple of USB VIDs for the API (qmk#7848) Add per-key IGNORE_MOD_TAP_INTERRUPT feature (qmk#7838) Refactor f103,f072,f042 based keyboards to use new MCU selection defaults (qmk#7705) ...
* initial commit from script * edit all generated files with my name and some basic notes * implement RGB Matrix support * cleanups, file removals, and readme edits * Update keyboards/bm60hsrgb/config.h * rename to bm60rgb * update included library and info.json keyboard name * Update keyboards/bm60rgb/keymaps/default/readme.md
* initial commit from script * edit all generated files with my name and some basic notes * implement RGB Matrix support * cleanups, file removals, and readme edits * Update keyboards/bm60hsrgb/config.h * rename to bm60rgb * update included library and info.json keyboard name * Update keyboards/bm60rgb/keymaps/default/readme.md
I'm having some issues with this pcb the underglow got turned off the moment I flashed it and all the commands for lighting I flashed onto it don't work. |
Underglow doesn't work. You cannot control it once you have flashed it. |
any idea how to fix it? |
Description
This is another port into QMK firmware from kbfirmware.com. This is a 60% with per key RGB leds. Customer who asked me to do this tested it and confirmed it working as I don't have an actual unit.
Types of Changes
Checklist