Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ADC support for STM32F3 and STM32F0 devices #7681

Merged
merged 3 commits into from
Mar 11, 2020
Merged

Add ADC support for STM32F3 and STM32F0 devices #7681

merged 3 commits into from
Mar 11, 2020

Conversation

Drewbadour
Copy link
Contributor

Description

Adds some spartan ADC support for STM32F0 and STM32F3 devices.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

If someone could point me in the right direction for adding ADC tests, I'd be happy to. Not sure how an ADC test would work though.

@drashna drashna requested a review from a team December 19, 2019 20:59
@zvecr zvecr mentioned this pull request Jan 10, 2020
Merged
@stale
Copy link

stale bot commented Feb 2, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Feb 2, 2020
@Drewbadour
Copy link
Contributor Author

Can I get any insight in to what is holding up this merge request? Is there more required from me?

@drashna drashna requested review from fauxpark, tzarc and zvecr March 1, 2020 01:40
drashna
drashna approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

And mostly, it just needs reviews.

@drashna drashna requested a review from a team March 1, 2020 01:41
noroadsleft
noroadsleft requested changes Mar 3, 2020
View reviewed changes
drivers/arm/analog.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 10, 2020 08:31
@Drewbadour Drewbadour requested review from noroadsleft and removed request for a team March 10, 2020 13:53
noroadsleft
noroadsleft approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak)) ✔️

Would like at least one of @fauxpark, @zvecr or @tzarc to give their approval; as I said, I'm out of my element here.

@tzarc tzarc merged commit 5ac6fe1 into qmk:master Mar 11, 2020
@tzarc
Copy link
Member

tzarc commented Mar 11, 2020

LGTM, guess we can fix stuff if they crop up later. Thanks!

@Drewbadour Drewbadour deleted the arm-adc branch March 15, 2020 13:51
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@FranticRain @c0psrul3
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
90b5cfa 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@FranticRain @sowbug
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
e34b41b 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
@FranticRain @HokieGeek
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
2beec79 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@FranticRain @kujawakk
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
64b9507 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@FranticRain @drashna
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
1eb3783 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@FranticRain @drashna
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
3dbd895 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
@FranticRain @fdidron
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
c4f12f9 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@FranticRain @jakobaa
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
7392177 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@FranticRain @jakeisnt
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
e7dfb90 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@FranticRain
Add ADC support for STM32F3 and STM32F0 devices (qmk#7681)
262fab8 
* Add ADC support for STM32F3 and STM32F0 devices

* Add section about configration options available to the ARM ADC implementation

* Fix STM32 typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
awaiting review core documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Drewbadour @tzarc @drashna @noroadsleft