-
-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom matrix from PS2AVRGB boards #7396
Conversation
All but one error seemed to be unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
My keymaps are erroring out due to the order that the mk files are being processed.... But that's 100% outside of the scope of this PR.
@coseyfannitutti can you verify the changes on your boards please? |
@sidcarter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
whooops, I don't have that keeb no moah. I can ask the one who has the keeb to try it out, but I don't think he's well versed with the QMK code. Suggestions to proceed? |
@fauxpark https://txkeyboards.com/images/virtuemart/product/65per.jpg Unfortunately, I don't have a more detailed pic. It looks as though as it's facing away from the switch? I could try to get a new pic from the new owner, if that doesn't work. |
I'm fairly confident now - the matrix.c from here is switching row pins and reading column pins, which is what the QMK matrix.c does when configured for COL2ROW. It looks like all the L3 PCBs have the same pinout between them, much like PS2AVRGB. (Finger65 config.h is missing the C2 pin for row 0, probably since it has no F keys) |
* Remove custom matrix from PS2AVRGB boards * Add custom backlight.c to SRC for bminiex, for now * Add missing DIODE_DIRECTIONs
* Remove custom matrix from PS2AVRGB boards * Add custom backlight.c to SRC for bminiex, for now * Add missing DIODE_DIRECTIONs
Description
All of this matrix code is unnecessary, as PS2AVRGB has a single common matrix pinout, and the core matrix.c can handle col2row.
Types of Changes
Issues Fixed or Closed by This PR
Checklist