-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Kyria keyboard to the repository #7222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From https://docs.qmk.fm/#/contributing?id=general-guidelines:
Separate PRs into logical units. For example, do not submit one PR covering two separate features, instead submit a separate PR for each feature.
Personally, I would like to see the core changes to oled driver and encoder pulled out into separate PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to agree with @zvecr here. The driver and quantum changes should be pulled out to a separate PR, as per our contributing guidelines.
Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
I have resolved most of the feedback, with some points of attention:
I still have a question regarding the |
* Added raw api for sending data directly to the buffer * Added default keymap variant * Applied proposed OLED display fix * Keymap progress * Keymap progress * Fixed inconsistent tabs * Fixed oled_write_raw apis * Updated keymap * Personal keymap * Added functionality to own keymap * Fixed spacing and build error * Keymap changes * Revert "Updated split encoders so indexes are based on left hand encoders first (qmk#6382)" This reverts commit 46c49ae. * Updated keymaps and configs * Revert "Revert "Updated split encoders so indexes are based on left hand encoders first (qmk#6382)"" This reverts commit f6a85fe. * Update keyboards/kyria/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rev1/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rules.mk Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rules.mk Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rev1/rev1.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rev1/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/rev1/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Processed keymap feedback * Reverted OLED raw API functionality
* Added raw api for sending data directly to the buffer * Added default keymap variant * Applied proposed OLED display fix * Keymap progress * Keymap progress * Fixed inconsistent tabs * Fixed oled_write_raw apis * Updated keymap * Personal keymap * Added functionality to own keymap * Fixed spacing and build error * Keymap changes * Revert "Updated split encoders so indexes are based on left hand encoders first (qmk#6382)" This reverts commit 46c49ae. * Updated keymaps and configs * Revert "Revert "Updated split encoders so indexes are based on left hand encoders first (qmk#6382)"" This reverts commit f6a85fe. * Update keyboards/kyria/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rev1/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rules.mk Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rules.mk Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rev1/rev1.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rev1/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/rev1/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Processed keymap feedback * Reverted OLED raw API functionality
* Added raw api for sending data directly to the buffer * Added default keymap variant * Applied proposed OLED display fix * Keymap progress * Keymap progress * Fixed inconsistent tabs * Fixed oled_write_raw apis * Updated keymap * Personal keymap * Added functionality to own keymap * Fixed spacing and build error * Keymap changes * Revert "Updated split encoders so indexes are based on left hand encoders first (qmk#6382)" This reverts commit 46c49ae. * Updated keymaps and configs * Revert "Revert "Updated split encoders so indexes are based on left hand encoders first (qmk#6382)"" This reverts commit f6a85fe. * Update keyboards/kyria/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rev1/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rules.mk Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rules.mk Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rev1/rev1.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/rev1/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/rev1/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/kyria/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/kyria/keymaps/thomasbaart/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Processed keymap feedback * Reverted OLED raw API functionality
Description
The Kyria is a new keyboard by Thomas Baart. With this pull request I'd like to add this keyboard to QMK's repository.
Types of Changes
Issues Fixed or Closed by This PR
There are no issues fixed or closed by this PR. Issue #7055 is related and can be reproduced on this keyboard with the attached keymaps.
Checklist
Considering the amount of intermediate changes, please squash the changes.