Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish translation for hardware documentation #7161

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Add Spanish translation for hardware documentation #7161

merged 4 commits into from
Oct 31, 2019

Conversation

michizhou
Copy link
Contributor

@michizhou michizhou commented Oct 26, 2019

Additional Spanish translation pages.

Description

Translates all hardware section documentation files as a supplement to existing translated pages.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yanfali
Copy link
Contributor

yanfali commented Oct 27, 2019

@michizhou is this Google translate?

@michizhou
Copy link
Contributor Author

michizhou commented Oct 27, 2019

@yanfali This isn't Google Translate. I studied Spanish for three years in high school.

I also just realized that I didn't finish my translations for all the hardware documentation. I will go translate the remaining files and push them for commit in a couple hours.

@noroadsleft
Copy link
Member

@namelivia and @kbravh Would you guys mind looking this over for us?

Copy link
Contributor

@kbravh kbravh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've begun adding some corrections, but I cannot finish them all now. I will continue reviewing tomorrow.

He corregido algunas cosas, pero agregaré más mañana.

docs/es/_summary.md Outdated Show resolved Hide resolved
docs/es/hardware.md Outdated Show resolved Hide resolved
docs/es/hardware.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
@namelivia
Copy link
Contributor

I'll review it too

Copy link
Contributor

@namelivia namelivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added fixes for many other pages, there is still one left to be reviewed

docs/es/_summary.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_avr.md Outdated Show resolved Hide resolved
docs/es/hardware_drivers.md Outdated Show resolved Hide resolved
docs/es/hardware_drivers.md Outdated Show resolved Hide resolved
docs/es/hardware_drivers.md Outdated Show resolved Hide resolved
docs/es/hardware_drivers.md Outdated Show resolved Hide resolved
docs/es/hardware_drivers.md Outdated Show resolved Hide resolved
docs/es/hardware_keyboard_guidelines.md Outdated Show resolved Hide resolved
docs/es/hardware_keyboard_guidelines.md Outdated Show resolved Hide resolved
docs/es/hardware_keyboard_guidelines.md Outdated Show resolved Hide resolved
docs/es/hardware_keyboard_guidelines.md Outdated Show resolved Hide resolved
docs/es/hardware_keyboard_guidelines.md Outdated Show resolved Hide resolved
docs/es/hardware_keyboard_guidelines.md Outdated Show resolved Hide resolved

En un esfuerzo por mantener el tamaño de repo abajo ya no estamos aceptando archivos binarios de cualquier formato, con pocas excepciones. Alojarlos en otro lugar (por ejemplo <https://imgur.com>) y enlazarlos en el `readme.md` es preferible.

Archivos de hardware (tales como placas, casos, pcb) se puede contribuir a la [qmk.fm repo](https://github.com/qmk/qmk.fm) y estarán disponibles en [qmk.fm](http://qmk.fm). Archivos descargables se almacenan en `/<teclado>/` (nombre sigue el mismo formato que el anterior) que se sirven en `http://qmk.fm/<teclado>/`, y se generan las páginas de `/_pages/<teclado>/` que se sirven en la misma ubicación (archivos .md se generan en archivos .html por Jekyll). Echa un vistazo a la carpeta` lets_s ' para un ejemplo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Archivos de hardware (tales como placas, casos, pcb) se puede contribuir a la [qmk.fm repo](https://github.com/qmk/qmk.fm) y estarán disponibles en [qmk.fm](http://qmk.fm). Archivos descargables se almacenan en `/<teclado>/` (nombre sigue el mismo formato que el anterior) que se sirven en `http://qmk.fm/<teclado>/`, y se generan las páginas de `/_pages/<teclado>/` que se sirven en la misma ubicación (archivos .md se generan en archivos .html por Jekyll). Echa un vistazo a la carpeta` lets_s ' para un ejemplo.
Para archivos de hardware (tales como placas, casos, pcb) puedes contribuir a [qmk.fm repo](https://github.com/qmk/qmk.fm) y estarán disponibles en [qmk.fm](http://qmk.fm). Archivos descargables se almacenan en `/<teclado>/` (nombre sigue el mismo formato que el anterior), se sirven en `http://qmk.fm/<teclado>/`, y se generan páginas de `/_pages/<teclado>/` que se sirven en la misma ubicación (Los archivos .md se transforman en archivos .html mediante Jekyll). Echa un vistazo a la carpeta` lets_s ' para ver un ejemplo.

@noroadsleft
Copy link
Member

I reviewed both @kbravh and @namelivia's reviews (so meta 😀) and verified that their suggestions were applied in 68f1775, save for this comment. My one suggestion is on the same line.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Me gusta!

@noroadsleft noroadsleft merged commit f4c8057 into qmk:master Oct 31, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* Add Spanish translation for hardware documentation

* Finished Spanish translations for hardware docs

* Resolved errors in Spanish page translations

* Corrected misspelled folder name in documentation

Co-Authored-By: Karey Higuera <karey.higuera@gmail.com>
Co-Authored-By: José Ignacio Amelivia Santiago <ohcan2@gmail.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* Add Spanish translation for hardware documentation

* Finished Spanish translations for hardware docs

* Resolved errors in Spanish page translations

* Corrected misspelled folder name in documentation

Co-Authored-By: Karey Higuera <karey.higuera@gmail.com>
Co-Authored-By: José Ignacio Amelivia Santiago <ohcan2@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Add Spanish translation for hardware documentation

* Finished Spanish translations for hardware docs

* Resolved errors in Spanish page translations

* Corrected misspelled folder name in documentation

Co-Authored-By: Karey Higuera <karey.higuera@gmail.com>
Co-Authored-By: José Ignacio Amelivia Santiago <ohcan2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants