Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minitomic keyboard #7140

Merged
merged 5 commits into from
Jan 13, 2020
Merged

Add minitomic keyboard #7140

merged 5 commits into from
Jan 13, 2020

Conversation

evyd13
Copy link
Contributor

@evyd13 evyd13 commented Oct 24, 2019

Description

Add my keyboard, the Minitomic, to the QMK repository.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/maartenwut/minitomic/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/readme.md Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/rules.mk Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/rules.mk Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/info.json Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/minitomic.h Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/minitomic.h Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/rules.mk Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/rules.mk Outdated Show resolved Hide resolved
Remove extra comma in info.json, move caps lock led status from keymap to keyboard, removes unused keys on full space bar layout, cleans up rules.mk and update readme blurb.
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just these three things on the readme. Everything else looks good to me.

keyboards/maartenwut/minitomic/readme.md Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/readme.md Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/readme.md Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Dec 17, 2019

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

@stale stale bot closed this Dec 17, 2019
@evyd13
Copy link
Contributor Author

evyd13 commented Dec 28, 2019

Could this be opened again?

@noroadsleft noroadsleft reopened this Dec 28, 2019
@stale stale bot removed the awaiting changes label Dec 28, 2019
keyboards/maartenwut/minitomic/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/maartenwut/minitomic/minitomic.c Show resolved Hide resolved
keyboards/maartenwut/minitomic/minitomic.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 29, 2019 01:33
Removes the custom keycodes in default keymap, fixes spacing in keymap and minitomic.c and puts the new led function in as well
@drashna drashna merged commit 94ea13e into qmk:master Jan 13, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* Add minitomic keyboard

* Small change to readme

* Make changes necessary for merging

Remove extra comma in info.json, move caps lock led status from keymap to keyboard, removes unused keys on full space bar layout, cleans up rules.mk and update readme blurb.

* Update readme.md

* Update led function, fix spacing and remove custom keycodes

Removes the custom keycodes in default keymap, fixes spacing in keymap and minitomic.c and puts the new led function in as well
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* Add minitomic keyboard

* Small change to readme

* Make changes necessary for merging

Remove extra comma in info.json, move caps lock led status from keymap to keyboard, removes unused keys on full space bar layout, cleans up rules.mk and update readme blurb.

* Update readme.md

* Update led function, fix spacing and remove custom keycodes

Removes the custom keycodes in default keymap, fixes spacing in keymap and minitomic.c and puts the new led function in as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants