Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add he-IL (Hebrew) Translation #7001

Merged
merged 26 commits into from
Oct 31, 2019
Merged

Add he-IL (Hebrew) Translation #7001

merged 26 commits into from
Oct 31, 2019

Conversation

GuyKh
Copy link
Contributor

@GuyKh GuyKh commented Oct 10, 2019

Description

Add Hebrew (he-IL) to the translated languages

Types of Changes

Translation

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@GuyKh
Copy link
Contributor Author

GuyKh commented Oct 10, 2019

@c-keys - I wish I wish I wish

@noroadsleft
Copy link
Member

@GuyKh can you rename the folder you're using for these to docs/he-il/? It is a bit non-standard, but we do want the folder paths to be fully lowercase for these translations. Thanks.

@noroadsleft noroadsleft mentioned this pull request Oct 10, 2019
Closed
@GuyKh
Copy link
Contributor Author

GuyKh commented Oct 11, 2019

@GuyKh can you rename the folder you're using for these to docs/he-il/? It is a bit non-standard, but we do want the folder paths to be fully lowercase for these translations. Thanks.

Done 👍

@drashna drashna requested a review from a team October 12, 2019 04:56
@ezuk
Copy link
Contributor

ezuk commented Oct 15, 2019

Looks good to me! ממש מגניב, כיף שיש תרגום בעברית.

@noroadsleft
Copy link
Member

@ezuk One more review please, if you could? ❤️

https://github.com/qmk/qmk_firmware/pull/7001/files/56df2d9142f52b861758586af52d9c6bac9aea5d..6f5eb1e07f9336d1fe01c93c807c23ea4fad8501

@GuyKh
Copy link
Contributor Author

GuyKh commented Oct 29, 2019

@noroadsleft - if you don't mind, I put a lot of effort into translating this, could I be eligible for a T-Shirt?
Thanks

@noroadsleft
Copy link
Member

@GuyKh We're tagging the eligible PRs after they get merged to cut down on comment noise. The listed requirement was four eligible interactions, but I realized a couple weeks ago that it takes quite a lot of effort to do high-quality translations – even more than I had anticipated. I'm hoping I can persuade the other members of the team that anyone who contributes substantially to a translation – either by doing the initial translation, reviewing translation PRs, or catching typos in an existing translation – should automatically qualify for the shirt (and I'm trying to make sure those users are credited as co-authors on the relevant PRs, because we can't do this without them).

Some other issues we've run into with these have been (these are all kind of related):

  • finding people we trust to review the translations, because none of us on the core team speak the language in question
  • finding people we trust to review the translations, because the user submitting the PR is unknown to us – maybe it's clear they know the language in question, but we have to verify they've read the original English docs and understand them, so the meanings of the translated docs don't change in subtle or confusing ways
  • translations where we can't verify the user submitting the translation actually knows the language in question – a couple of PRs have been Google Translate submissions, which aren't high-quality

For your PR specifically, I like to have ezuk's approval again, but if he doesn't get to it, I'll merge it tomorrow.

@GuyKh
Copy link
Contributor Author

GuyKh commented Oct 29, 2019

@noroadsleft Thanks a lot for your detailed response. :)

@noroadsleft
Copy link
Member

Thanks for your contribution! Sorry about the delay!

@noroadsleft noroadsleft merged commit 742e83e into qmk:master Oct 31, 2019
@GuyKh GuyKh deleted the he-IL-translation branch October 31, 2019 19:29
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@GuyKh
[Docs] Add he-IL (Hebrew) Translation (qmk#7001)
5f9542f 
* Add he-IL (Hebrew) Translation

* Add Hebrew to SUMMARY

* Try RTL

* Add RTL text

* Lowercase folder names

* Update lowercase folder in Summary

* Adding getting_started_introduction.md

* Add Proton C Conversion translation

* Add Becoming a QMK Collaborator Translation

* Add FAQ translation

* Add Hardware translation

* Documentation Best Practices translation

* Add FAQ General translation

* Align docs RTL

*  Add Becoming a QMK Collaborator Translation

* Translate Getting Started - Getting Help

* Translate Getting Started With Github

* Code sections should be alligned to the left

* Code sections should be alligned to the left

* Code sections should be alligned to the left

* Revert "Code sections should be alligned to the left"

This reverts commit d0c46e9.

* Add Markdown aligned to the left

* Update quantum_keycodes.md

* Update proton_c_conversion.md

* Translate Newbs Learn More Resourses
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@GuyKh @HokieGeek
[Docs] Add he-IL (Hebrew) Translation (qmk#7001)
e9abec3 
* Add he-IL (Hebrew) Translation

* Add Hebrew to SUMMARY

* Try RTL

* Add RTL text

* Lowercase folder names

* Update lowercase folder in Summary

* Adding getting_started_introduction.md

* Add Proton C Conversion translation

* Add Becoming a QMK Collaborator Translation

* Add FAQ translation

* Add Hardware translation

* Documentation Best Practices translation

* Add FAQ General translation

* Align docs RTL

*  Add Becoming a QMK Collaborator Translation

* Translate Getting Started - Getting Help

* Translate Getting Started With Github

* Code sections should be alligned to the left

* Code sections should be alligned to the left

* Code sections should be alligned to the left

* Revert "Code sections should be alligned to the left"

This reverts commit d0c46e9.

* Add Markdown aligned to the left

* Update quantum_keycodes.md

* Update proton_c_conversion.md

* Translate Newbs Learn More Resourses
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@GuyKh @noroadsleft
[Docs] Add he-IL (Hebrew) Translation (qmk#7001)
0bb29af 
* Add he-IL (Hebrew) Translation

* Add Hebrew to SUMMARY

* Try RTL

* Add RTL text

* Lowercase folder names

* Update lowercase folder in Summary

* Adding getting_started_introduction.md

* Add Proton C Conversion translation

* Add Becoming a QMK Collaborator Translation

* Add FAQ translation

* Add Hardware translation

* Documentation Best Practices translation

* Add FAQ General translation

* Align docs RTL

*  Add Becoming a QMK Collaborator Translation

* Translate Getting Started - Getting Help

* Translate Getting Started With Github

* Code sections should be alligned to the left

* Code sections should be alligned to the left

* Code sections should be alligned to the left

* Revert "Code sections should be alligned to the left"

This reverts commit d0c46e9.

* Add Markdown aligned to the left

* Update quantum_keycodes.md

* Update proton_c_conversion.md

* Translate Newbs Learn More Resourses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@ezuk ezuk ezuk approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuyKh @noroadsleft @ezuk @guyk-yahoo