Fix the keyboard template with new make syntax #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add proper link to the parent
|
Thanks! |
BlueTufa
pushed a commit
to BlueTufa/qmk_firmware
that referenced
this pull request
Aug 6, 2021
* Clean up icon handling. - sort icons - make only a single API call instead of N * minor promise cleanups * corner case when loading preview * WIP - Clean up legacy uses of store - Move calls into map Helpers - Fix mime-type of JSON download - catch harmless routing error if you route to say keyboard * remove last getters * typo
petrovs12
pushed a commit
to petrovs12/qmk_firmware_sval
that referenced
this pull request
May 21, 2024
* Add Simple75 * Add Default keymap * Flip encoder orientation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add proper link to the parent
I noticed these problems when adding the Infinity60 readme. The make instructions for all the keyboards were already updated, but not the template.
The link to the parent has not been changed for existing keyboards, since I'm not fully sure that it will work properly on the qmk.fm site.