Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ergodox: Update algernon's keymap to v1.6 #678

Merged
merged 1 commit into from
Sep 6, 2016
Merged

ergodox: Update algernon's keymap to v1.6 #678

merged 1 commit into from
Sep 6, 2016

Conversation

algernon
Copy link
Contributor

Base layer changes

  • The parentheses & bracket keys have been merged: tapping them results in [ or { (if it was shifted), double tapping leads to (.
  • The :; and -_ keys are now available on the base layer, on their ADORE location, too, just below [{(/]}).
  • The Apps key has been replaced by F12.
  • The -/_ is no longer a tap-dance key.

ADORE layer changes

  • Adjustments were made to the ADORE layer, to separate some inconvenient combinations.

Miscellaneous changes

  • LEAD u now starts the symbolic unicode input system, instead of the OS-one.
  • The mouse acceleration keys on the *Navigation and Media layer have been turned into toggles: tap them once to turn them on, until tapped again. Tapping an accelerator button will turn all the others off.
  • When the ARROW layer is on, the red and blue LEDs light up now.

Heatmap

  • The built-in keylogger has been greatly enhanced, it now outputs the pressed state, and the layer (Dvorak or ADORE). As such, the ADORE_AUTOLOG option has been removed, instead there is AUTOLOG_ENABLE now, which when enabled, makes the keylogger start when the keyboard boots. It defaults to off.
  • The heatmap generator received a lot of updates.

@fredizzimo
Copy link
Contributor

It appears like the qk_ucis_state definition should be moved to process_unicode.c instead of process_unicode.h to avoid getting it declared in multiple objects. And of course make the declaration extern.

@algernon
Copy link
Contributor Author

Hm. How did I not spot this?

@fredizzimo
Copy link
Contributor

fredizzimo commented Aug 24, 2016

Maybe because the error only happens on Infinity for some reason, but without a much deeper investigation I have no idea why.

Edit: It would be nice if Travis could send e-mail notifications when the build fails.
Edit2: It seems like it's actually possible https://docs.travis-ci.com/user/notifications/

@algernon
Copy link
Contributor Author

#679 should fix the error, it does so locally. Thanks @fredizzimo for the hint!

Major changes include:

Base layer changes
------------------

* The parentheses & bracket keys have been merged: tapping them results
  in `[` or `{` (if it was shifted), double tapping leads to `(`.
* The `:;` and `-_` keys are now available on the base layer, on
  their **ADORE** location, too, just below `[{(`/`]})`.
* The `Apps` key has been replaced by `F12`.
* The `-`/`_` is no longer a tap-dance key.

ADORE layer changes
-------------------

* Adjustments were made to the **ADORE** layer, to separate some
  inconvenient combinations.

Miscellaneous changes
---------------------

* `LEAD u` now starts the symbolic unicode input system, instead of the
  OS-one.
* The mouse acceleration keys on the **Navigation and Media* layer have
  been turned into toggles: tap them once to turn them on, until tapped
  again. Tapping an accelerator button will turn all the others off.
* When the **ARROW** layer is on, the *red* and *blue* LEDs light up
  now.

Heatmap
-------

* The built-in keylogger has been greatly enhanced, it now outputs the
  pressed state, and the layer (Dvorak or ADORE). As such, the
  `ADORE_AUTOLOG` option has been removed, instead there is
  `AUTOLOG_ENABLE` now, which when enabled, makes the keylogger start
  when the keyboard boots. It defaults to off.
* The heatmap generator received a lot of updates.

Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
@algernon
Copy link
Contributor Author

There we go, rebased on top of current master, all green!

@ezuk
Copy link
Contributor

ezuk commented Aug 26, 2016

@fredizzimo all good here?

Thank you @algernon! Your keymaps are a form of art :)

@fredizzimo
Copy link
Contributor

@ezuk, yes. I see no other problems than that this keymap is so good that it makes me wish that I had more time to make my own 👍

@ezuk
Copy link
Contributor

ezuk commented Sep 6, 2016

Yay! Merging (fashionably late, very sorry for that).

@ezuk ezuk merged commit 45d6848 into qmk:master Sep 6, 2016
BlueTufa pushed a commit to BlueTufa/qmk_firmware that referenced this pull request Aug 6, 2021
* '\n' must be parsed as a new line

* Fix CSV definition instead of parsing process
rti pushed a commit to rti/qmk_firmware that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants