Redox_w Use layer_state_set_user instead of matrix_scan_user #6608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelbreaker
changed the title
|
Looks good to me! :) |
drashna
reviewed
Aug 25, 2019
|
|
||
| switch (layer) { | ||
| layer_state_t layer_state_set_user(layer_state_t state) { | ||
| switch (get_highest_layer(state)) { |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Aug 27, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (42 commits) pegasushoof Specify the bootloader to use :flash (qmk#6614) Fix Typo in :flash target for missing bootloader (qmk#6615) Mars80 Bug: Physical/Electrical Matrix Mismatch (qmk#6612) [Keymap] Redox_w Use layer_state_set_user instead of matrix_scan_user (qmk#6608) Added OLED Display autoscroll during periods of OLED data inactivity (qmk#6546) Refactor `qmk compile-json` to `qmk compile` (qmk#6592) RGB Inidcator example for new van pcbs (qmk#6544) Add new 60% Tsangan HHKB layout (qmk#6607) [Keyboard] Maartenwut Wonderland PCB (qmk#6492) Add 2015 revision of Pegasus Hoof to QMK (qmk#6595) [Keyboard] New Keyboard: EVE Meteor (qmk#6565) updates the coc [Keymap] a keymap to "transform" a jj40 info a simil Alpha28, to enjoy its simplicity and power (qmk#6599) [Keyboard] Add JNAO keyboard (qmk#6598) [Keymap] ISO keymap for TADA68 with programming in mind (qmk#6597) [Keymap] Update to userspace kuchosauroand0 (qmk#6596) Add 'bootloadHID' flash target (qmk#5587) Add Zadig 101 to docs (qmk#6585) Add Soft Serial Speed to Diverge3 keyboard config for compatibility (qmk#5076) Added 4by3 keyboard (qmk#6547) ...
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
…qmk#6608) * use layer_state_set_user * fix
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
…qmk#6608) * use layer_state_set_user * fix
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
…qmk#6608) * use layer_state_set_user * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from updating the LED state on every
matrix_scan_usertolayer_state_set_userwhich as I understand it is preferable.FAO @mattdibi