Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JNAO keyboard #6598

Merged
merged 6 commits into from
Aug 24, 2019
Merged

Add JNAO keyboard #6598

merged 6 commits into from
Aug 24, 2019

Conversation

nooges
Copy link
Member

@nooges nooges commented Aug 23, 2019

Description

Adds JNAO keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/jnao/keymaps/bakingpy/keymap.c Outdated Show resolved Hide resolved
keyboards/jnao/keymaps/bakingpy/keymap.c Outdated Show resolved Hide resolved
keyboards/jnao/keymaps/bakingpy/keymap.c Outdated Show resolved Hide resolved
keyboards/jnao/keymaps/bakingpy/keymap.c Outdated Show resolved Hide resolved
keyboards/jnao/keymaps/bakingpy/keymap.c Outdated Show resolved Hide resolved
keyboards/jnao/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jnao/keymaps/default_4x12/keymap.c Outdated Show resolved Hide resolved
keyboards/jnao/keymaps/default_4x12/keymap.c Outdated Show resolved Hide resolved
keyboards/jnao/keymaps/default_4x12/keymap.c Outdated Show resolved Hide resolved
keyboards/jnao/rules.mk Outdated Show resolved Hide resolved
@noroadsleft noroadsleft requested a review from a team August 23, 2019 21:53
@drashna
Copy link
Member

drashna commented Aug 23, 2019

Don't we have a number of keyboards from Chris now? Maybe we should move this and other boards to /keyboards/maple_computing/ or some such?

@nooges
Copy link
Member Author

nooges commented Aug 24, 2019

@drashna Chris is more of a white-label producer of boards, I don't think he really wants to directly handle any kind of support

@nooges
Copy link
Member Author

nooges commented Aug 24, 2019

Ready for re-review

@drashna
Copy link
Member

drashna commented Aug 24, 2019

Well, I was thinking more from an organizational standpoint, rather than support. But either way is fine.

@drashna drashna merged commit 2c8d8be into qmk:master Aug 24, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 27, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (42 commits)
  pegasushoof Specify the bootloader to use :flash (qmk#6614)
  Fix Typo in :flash target for missing bootloader (qmk#6615)
  Mars80 Bug: Physical/Electrical Matrix Mismatch (qmk#6612)
  [Keymap] Redox_w Use layer_state_set_user instead of matrix_scan_user (qmk#6608)
  Added OLED Display autoscroll during periods of OLED data inactivity (qmk#6546)
  Refactor `qmk compile-json` to `qmk compile` (qmk#6592)
  RGB Inidcator example for new van pcbs (qmk#6544)
  Add new 60% Tsangan HHKB layout (qmk#6607)
  [Keyboard] Maartenwut Wonderland PCB (qmk#6492)
  Add 2015 revision of Pegasus Hoof to QMK (qmk#6595)
  [Keyboard] New Keyboard: EVE Meteor (qmk#6565)
  updates the coc
  [Keymap] a keymap to "transform" a jj40 info a simil Alpha28, to enjoy its simplicity and power (qmk#6599)
  [Keyboard] Add JNAO keyboard (qmk#6598)
  [Keymap] ISO keymap for TADA68 with programming in mind (qmk#6597)
  [Keymap] Update to userspace kuchosauroand0 (qmk#6596)
  Add 'bootloadHID' flash target (qmk#5587)
  Add Zadig 101 to docs (qmk#6585)
  Add Soft Serial Speed to Diverge3 keyboard config for compatibility (qmk#5076)
  Added 4by3 keyboard (qmk#6547)
  ...
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
* Add JNAO keyboard

* Use layout macro for default_4x12

* Add bakingpy keymap

* Add info.json data

* Remove bakingpy keymap from jnao, add ortho_4x12 layout fetching

* Clear up default keymaps
@nooges nooges deleted the add-jnao branch September 2, 2019 17:02
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
* Add JNAO keyboard

* Use layout macro for default_4x12

* Add bakingpy keymap

* Add info.json data

* Remove bakingpy keymap from jnao, add ortho_4x12 layout fetching

* Clear up default keymaps
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* Add JNAO keyboard

* Use layout macro for default_4x12

* Add bakingpy keymap

* Add info.json data

* Remove bakingpy keymap from jnao, add ortho_4x12 layout fetching

* Clear up default keymaps
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* Add JNAO keyboard

* Use layout macro for default_4x12

* Add bakingpy keymap

* Add info.json data

* Remove bakingpy keymap from jnao, add ortho_4x12 layout fetching

* Clear up default keymaps
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Add JNAO keyboard

* Use layout macro for default_4x12

* Add bakingpy keymap

* Add info.json data

* Remove bakingpy keymap from jnao, add ortho_4x12 layout fetching

* Clear up default keymaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants