-
-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RGB Inidcator example for new van pcbs #6544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
reviewed
Aug 15, 2019
keyboards/thevankeyboards/minivan/keymaps/jetpacktuxedo/config.h
Outdated
Show resolved
Hide resolved
Put together a little video demo: |
drashna
approved these changes
Aug 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
mechmerlin
approved these changes
Aug 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Aug 27, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (42 commits) pegasushoof Specify the bootloader to use :flash (qmk#6614) Fix Typo in :flash target for missing bootloader (qmk#6615) Mars80 Bug: Physical/Electrical Matrix Mismatch (qmk#6612) [Keymap] Redox_w Use layer_state_set_user instead of matrix_scan_user (qmk#6608) Added OLED Display autoscroll during periods of OLED data inactivity (qmk#6546) Refactor `qmk compile-json` to `qmk compile` (qmk#6592) RGB Inidcator example for new van pcbs (qmk#6544) Add new 60% Tsangan HHKB layout (qmk#6607) [Keyboard] Maartenwut Wonderland PCB (qmk#6492) Add 2015 revision of Pegasus Hoof to QMK (qmk#6595) [Keyboard] New Keyboard: EVE Meteor (qmk#6565) updates the coc [Keymap] a keymap to "transform" a jj40 info a simil Alpha28, to enjoy its simplicity and power (qmk#6599) [Keyboard] Add JNAO keyboard (qmk#6598) [Keymap] ISO keymap for TADA68 with programming in mind (qmk#6597) [Keymap] Update to userspace kuchosauroand0 (qmk#6596) Add 'bootloadHID' flash target (qmk#5587) Add Zadig 101 to docs (qmk#6585) Add Soft Serial Speed to Diverge3 keyboard config for compatibility (qmk#5076) Added 4by3 keyboard (qmk#6547) ...
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
* RGB Inidcator example for new van pcbs * simplify config.h As per @drashna in CR
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
* RGB Inidcator example for new van pcbs * simplify config.h As per @drashna in CR
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
* RGB Inidcator example for new van pcbs * simplify config.h As per @drashna in CR
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
* RGB Inidcator example for new van pcbs * simplify config.h As per @drashna in CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added rgb pin definitions for the minivan (hotswap pcbs have three top-facing rgb indicators on the top left) as well as added an example of usage in my personal keymap. I also dropped a bunch of commented-out and dead code from the minivan core files, and made a tiny change to my keymap.
Types of Changes
Checklist