Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "ridingqwerty" user and keymap for atreus keyboard #6533

Merged
merged 14 commits into from
Aug 16, 2019
Merged

add "ridingqwerty" user and keymap for atreus keyboard #6533

merged 14 commits into from
Aug 16, 2019

Conversation

ridingqwerty
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Aug 13, 2019
View reviewed changes
keyboards/atreus/keymaps/ridingqwerty/atreus.c Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ridingqwerty/atreus.c Outdated Show resolved Hide resolved
ridingqwerty and others added 2 commits August 13, 2019 12:46
@ridingqwerty @zvecr
Update keyboards/atreus/keymaps/ridingqwerty/atreus.c
faefdeb 
Co-Authored-By: Joel Challis <git@zvecr.com>
@ridingqwerty @zvecr
Update keyboards/atreus/keymaps/ridingqwerty/atreus.c
63608bc 
Co-Authored-By: Joel Challis <git@zvecr.com>
@ridingqwerty
Copy link
Contributor Author

I believe I've merged the requested changes correctly but please let me know if this is still pending anything from me.

drashna
drashna requested changes Aug 14, 2019
View reviewed changes
keyboards/atreus/keymaps/ridingqwerty/atreus.h Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ridingqwerty/atreus.c Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ridingqwerty/keymap.c Outdated Show resolved Hide resolved
mechmerlin
mechmerlin approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noroadsleft
noroadsleft approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from drashna August 16, 2019 21:52
drashna
drashna approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@drashna drashna merged commit 0c03811 into qmk:master Aug 16, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 18, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
d293fa6 
* 'master' of https://github.com/qmk/qmk_firmware: (53 commits)
  Add ATmega32U2 to mcu_selection.mk (qmk#6561)
  Reword a note about the MANUFACTURER and PRODUCT defines in hardware_avr.md (qmk#6558)
  Userspace kuchosauronad0 (qmk#6541)
  Illustrate the emoji layer (qmk#6555)
  Remove backslashes from template keymap (qmk#6548)
  [Keymap] add niu_mini custom keymaps (qmk#6552)
  [Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#6533)
  Add support for different encoder pinout for right half of split keyboard (qmk#6521)
  Fix Clueboard hotswap gen1 not compiling when LED Matrix is disabled (qmk#6427)
  Add an alternative method for keyboard discovery to speed up build (qmk#6073)
  Refactor of lets_split_eh to enable RGB split animations (qmk#6411)
  Remove duplicate test keyboards (qmk#6539)
  [Keymap] Fix include following Wilba refactor (qmk#6538)
  [Keymap] Cosmetic fix for default Wasdat keymaps (qmk#6531)
  [Keymap] Xd75 bulbizarre keymap (qmk#6525)
  [Keymap] Update gherkin to use gpio (qmk#6520)
  [Keyboard] Align xd84 and xd96 with moon (qmk#6465)
  Enable PWM Support for Planck EZ Indicator Lights  (qmk#6473)
  [Keyboard] Add: Initial steamvan firmware code (qmk#6501)
  [Keymap] Adding my userspace and keymaps (qmk#6496)
  ...
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@ridingqwerty @doughsay
[Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#…
7a7b58d 
…6533)

* add userspace and atreus keymap

* cleaning up notes/comments

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Create readme.md

* remove reference to matrix_init_kb from atreus.c

* correct atreus.c

* remove unnecessary defines

* merge register/unregister sequence into single tapcode

* move 'LAYOUT to keymap.c; remove atreus.h

* remove TAPPING_TERM from keyboard-level config.h
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
@ridingqwerty @drashna
[Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#…
0066561 
…6533)

* add userspace and atreus keymap

* cleaning up notes/comments

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Create readme.md

* remove reference to matrix_init_kb from atreus.c

* correct atreus.c

* remove unnecessary defines

* merge register/unregister sequence into single tapcode

* move 'LAYOUT to keymap.c; remove atreus.h

* remove TAPPING_TERM from keyboard-level config.h
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@ridingqwerty
[Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#…
031d03b 
…6533)

* add userspace and atreus keymap

* cleaning up notes/comments

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Create readme.md

* remove reference to matrix_init_kb from atreus.c

* correct atreus.c

* remove unnecessary defines

* merge register/unregister sequence into single tapcode

* move 'LAYOUT to keymap.c; remove atreus.h

* remove TAPPING_TERM from keyboard-level config.h
ridingqwerty added a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@ridingqwerty @drashna
[Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#…
5f81aa4 
…6533)

* add userspace and atreus keymap

* cleaning up notes/comments

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Create readme.md

* remove reference to matrix_init_kb from atreus.c

* correct atreus.c

* remove unnecessary defines

* merge register/unregister sequence into single tapcode

* move 'LAYOUT to keymap.c; remove atreus.h

* remove TAPPING_TERM from keyboard-level config.h
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@ridingqwerty @drashna
[Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#…
b877279 
…6533)

* add userspace and atreus keymap

* cleaning up notes/comments

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Update keyboards/atreus/keymaps/ridingqwerty/atreus.c

Co-Authored-By: Joel Challis <git@zvecr.com>

* Create readme.md

* remove reference to matrix_init_kb from atreus.c

* correct atreus.c

* remove unnecessary defines

* merge register/unregister sequence into single tapcode

* move 'LAYOUT to keymap.c; remove atreus.h

* remove TAPPING_TERM from keyboard-level config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ridingqwerty @drashna @zvecr @noroadsleft @mechmerlin @GeorgeKoenig