Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gherkin CTPC compatibility - Update to use gpio #6520

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 10, 2019

Description

Reported on Discord by mikethetiger. make 40percentclub/gherkin:default CTPC=yes fails due to AVR specific code in the default keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keymap label Aug 10, 2019
@zvecr zvecr requested a review from a team August 10, 2019 23:56
@zvecr zvecr requested a review from a team August 12, 2019 06:55
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@drashna drashna merged commit d14ef52 into qmk:master Aug 14, 2019
incredibleweirdo pushed a commit to electricbrainreserve/qmk_firmware that referenced this pull request Aug 15, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 18, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (53 commits)
  Add ATmega32U2 to mcu_selection.mk (qmk#6561)
  Reword a note about the MANUFACTURER and PRODUCT defines in hardware_avr.md (qmk#6558)
  Userspace kuchosauronad0 (qmk#6541)
  Illustrate the emoji layer (qmk#6555)
  Remove backslashes from template keymap (qmk#6548)
  [Keymap] add niu_mini custom keymaps (qmk#6552)
  [Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#6533)
  Add support for different encoder pinout for right half of split keyboard (qmk#6521)
  Fix Clueboard hotswap gen1 not compiling when LED Matrix is disabled (qmk#6427)
  Add an alternative method for keyboard discovery to speed up build (qmk#6073)
  Refactor of lets_split_eh to enable RGB split animations (qmk#6411)
  Remove duplicate test keyboards (qmk#6539)
  [Keymap] Fix include following Wilba refactor (qmk#6538)
  [Keymap] Cosmetic fix for default Wasdat keymaps (qmk#6531)
  [Keymap] Xd75 bulbizarre keymap (qmk#6525)
  [Keymap] Update gherkin to use gpio (qmk#6520)
  [Keyboard] Align xd84 and xd96 with moon (qmk#6465)
  Enable PWM Support for Planck EZ Indicator Lights  (qmk#6473)
  [Keyboard] Add: Initial steamvan firmware code (qmk#6501)
  [Keymap] Adding my userspace and keymaps (qmk#6496)
  ...
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@zvecr zvecr deleted the feature/gherkin_ctpc branch April 28, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants