Enable PWM Support for Planck EZ Indicator Lights #6473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackhumbert
reviewed
Aug 2, 2019
drashna
commented
Aug 5, 2019
zvecr
reviewed
Aug 8, 2019
zvecr
approved these changes
Aug 9, 2019
13 tasks
jackhumbert
approved these changes
Aug 13, 2019
incredibleweirdo
pushed a commit
to electricbrainreserve/qmk_firmware
that referenced
this pull request
Aug 15, 2019
* remove led layer code * enable PWM on STM32F303 * Unusable PWM code * Updated PWM Stuff? * PWM Semi-working * Both LEDs working at the same time * Update names * Add led level functions * Add LED levels and persistent settings * Revert change due to issues with timing related code * Review feedback and minor cleanup
|
unsure if this is the right place... the indicator lights don't appear to work as intended. if the left or right layer buttons are pressed, they work, but the LEDs do not light up. if both are pressed, they work, but only the left LED turns on. |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Aug 18, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (53 commits) Add ATmega32U2 to mcu_selection.mk (qmk#6561) Reword a note about the MANUFACTURER and PRODUCT defines in hardware_avr.md (qmk#6558) Userspace kuchosauronad0 (qmk#6541) Illustrate the emoji layer (qmk#6555) Remove backslashes from template keymap (qmk#6548) [Keymap] add niu_mini custom keymaps (qmk#6552) [Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#6533) Add support for different encoder pinout for right half of split keyboard (qmk#6521) Fix Clueboard hotswap gen1 not compiling when LED Matrix is disabled (qmk#6427) Add an alternative method for keyboard discovery to speed up build (qmk#6073) Refactor of lets_split_eh to enable RGB split animations (qmk#6411) Remove duplicate test keyboards (qmk#6539) [Keymap] Fix include following Wilba refactor (qmk#6538) [Keymap] Cosmetic fix for default Wasdat keymaps (qmk#6531) [Keymap] Xd75 bulbizarre keymap (qmk#6525) [Keymap] Update gherkin to use gpio (qmk#6520) [Keyboard] Align xd84 and xd96 with moon (qmk#6465) Enable PWM Support for Planck EZ Indicator Lights (qmk#6473) [Keyboard] Add: Initial steamvan firmware code (qmk#6501) [Keymap] Adding my userspace and keymaps (qmk#6496) ...
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
* remove led layer code * enable PWM on STM32F303 * Unusable PWM code * Updated PWM Stuff? * PWM Semi-working * Both LEDs working at the same time * Update names * Add led level functions * Add LED levels and persistent settings * Revert change due to issues with timing related code * Review feedback and minor cleanup
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
* remove led layer code * enable PWM on STM32F303 * Unusable PWM code * Updated PWM Stuff? * PWM Semi-working * Both LEDs working at the same time * Update names * Add led level functions * Add LED levels and persistent settings * Revert change due to issues with timing related code * Review feedback and minor cleanup
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
* remove led layer code * enable PWM on STM32F303 * Unusable PWM code * Updated PWM Stuff? * PWM Semi-working * Both LEDs working at the same time * Update names * Add led level functions * Add LED levels and persistent settings * Revert change due to issues with timing related code * Review feedback and minor cleanup
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
* remove led layer code * enable PWM on STM32F303 * Unusable PWM code * Updated PWM Stuff? * PWM Semi-working * Both LEDs working at the same time * Update names * Add led level functions * Add LED levels and persistent settings * Revert change due to issues with timing related code * Review feedback and minor cleanup
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* remove led layer code * enable PWM on STM32F303 * Unusable PWM code * Updated PWM Stuff? * PWM Semi-working * Both LEDs working at the same time * Update names * Add led level functions * Add LED levels and persistent settings * Revert change due to issues with timing related code * Review feedback and minor cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title....
Specifically, this switches the indicator lights (under the spacebar) from on/off, to PWM, which allows for dimming.
Additionally. this adds the ability to dim the LEDs via a keycode.
Types of Changes
Checklist