Added Space Cadet modifer carry over #5866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
reviewed
May 14, 2019
XScorpion2
changed the title
drashna
requested review from
drashna,
algernon,
ezuk,
fredizzimo,
jackhumbert,
mechmerlin,
noroadsleft,
qmk-bot,
skullydazed and
yanfali
and removed request for
qmk-bot
drashna
approved these changes
May 19, 2019
XScorpion2
force-pushed
the
features/space_cadet_carry
branch
from
f8fcce5 to
dc43b45
Compare
XScorpion2
force-pushed
the
features/space_cadet_carry
branch
from
dc43b45 to
6dcfc84
Compare
Update docs/feature_space_cadet.md Co-Authored-By: fauxpark <fauxpark@gmail.com>
XScorpion2
force-pushed
the
features/space_cadet_carry
branch
from
6dcfc84 to
db44a9f
Compare
|
Rebased on latest master |
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jul 12, 2019
Co-Authored-By: fauxpark <fauxpark@gmail.com>
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jul 27, 2019
Co-Authored-By: fauxpark <fauxpark@gmail.com>
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
Update docs/feature_space_cadet.md Co-Authored-By: fauxpark <fauxpark@gmail.com>
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
Update docs/feature_space_cadet.md Co-Authored-By: fauxpark <fauxpark@gmail.com>
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
Update docs/feature_space_cadet.md Co-Authored-By: fauxpark <fauxpark@gmail.com>
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
Update docs/feature_space_cadet.md Co-Authored-By: fauxpark <fauxpark@gmail.com>
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
Update docs/feature_space_cadet.md Co-Authored-By: fauxpark <fauxpark@gmail.com>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Update docs/feature_space_cadet.md Co-Authored-By: fauxpark <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an option for those fast typing folks that carry over the mods from when you pressed the space cadet key to the release. For example: Press Shift > Press KC_LSPO > Release Shift > Release KC_LSPO. In this example, since KC_LSPO tap triggers on release, it will not contain the Shift modifier from when it was pressed. This define will carry over the modifiers from when it was pressed and use them on tap trigger release. This is super useful when using a setup like this and fast typing to get both { & [ based on if the other shift is held down or not.
Types of Changes
Issues Fixed or Closed by This PR
Checklist