Fix incorrect keyboard dimensions in Configurator API data #5615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested review from
drashna,
ezuk,
jackhumbert,
mechmerlin,
skullydazed and
yanfali
drashna
approved these changes
Apr 13, 2019
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
* Fix Ergodone keyboard dimensions in info.json * Fix handwired/prime_exl keyboard dimensions in info.json * Fix KBDfans KBD4x keyboard dimensions in info.json * Fix handwired/not_so_minidox keyboard dimensions in info.json * Fix Canoe keyboard dimensions in info.json * Fix Clueboard Cluecard keyboard dimensions in info.json * Fix Corne (crkbd) keyboard dimensions in info.json * Fix Gergo keyboard dimensions in info.json * Fix handwired/frenchdev keyboard dimensions in info.json * Fix handwired/ortho5x13 keyboard dimensions in info.json * Fix handwired/promethium keyboard dimensions in info.json * Fix Speedo keyboard dimensions in info.json * Fix XD87 keyboard dimensions in info.json * Fix Ergodox EZ keyboard dimensions in info.json * Fix Ergodox Infinity keyboard dimensions in info.json * Fix Keeb.io Iris keyboard dimensions in info.json * Fix Orthodox keyboard dimensions in info.json (all revisions) * Fix Qwertyydox keyboard dimensions in info.json * Fix handwired/tradestation keyboard dimensions in info.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These commits edit the keyboard metadata so the given dimensions in the API are correct, according to the layout data.
Checking was prompted by a report from @i5ar in #4098.
For reference:
Notes
I have a table of the keyboard maintainers whose boards are affected by this that I can post, if necessary. I consider this a minor change, but you never really know. Didn't want to spam out a whole bunch of notifications.
PLEASE SQUASH AND MERGE WHEN ACCEPTABLE.