Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tx Bolt ghosting second character on key press #5229

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Fix Tx Bolt ghosting second character on key press #5229

merged 2 commits into from
Feb 24, 2019

Conversation

tschulte
Copy link
Contributor

@tschulte tschulte commented Feb 23, 2019 •
edited by drashna
Loading

Description

Fix missing break; in switch statement.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tschulte
convert tabs to spaces
b2cdc36
@tschulte
fix qmk#4578: don't call gemini protocol code when in bolt mode
86617d8 
Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.
@drashna drashna added bug core and removed core labels Feb 24, 2019
@drashna
Copy link
Member

drashna commented Feb 24, 2019

Thanks!

@drashna drashna merged commit a69e440 into qmk:master Feb 24, 2019
@tschulte tschulte deleted the fixTxBolt branch March 1, 2019 13:11
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
@tschulte @slugger7
Fix Tx Bolt ghosting second character on key press (qmk#5229)
f4ecad8 
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 18, 2019
@tschulte @zer09
Fix Tx Bolt ghosting second character on key press (qmk#5229)
2281bbb 
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
@tschulte @chie4hao
Fix Tx Bolt ghosting second character on key press (qmk#5229)
302cdaf 
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
@tschulte @slugger7
Fix Tx Bolt ghosting second character on key press (qmk#5229)
ed25e54 
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@tschulte
Fix Tx Bolt ghosting second character on key press (qmk#5229)
56895ee 
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XScorpion2 XScorpion2 XScorpion2 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tx Bolt ghosting second character on key press steno is outputting incorrect keystrokes
3 participants
@tschulte @drashna @XScorpion2