Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create KPrepublic directory #5206

Closed
wants to merge 13 commits into from
Closed

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 21, 2019

Description

To reduce clutter in the keyboards/ directory, this PR adds a kprepublic folder to collate all boards under one parent.

Should move as they currently mention kprepublic:

  • cospad
  • daisy
  • staryu
  • jj40
  • jj50
  • jj4x4
  • xd84
  • xd87

Note: I will do a 2nd pass and refactor each board to the current standards, including use of i2c as a separate set of PRs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin
Copy link
Contributor

I'm a little concerned about putting in XD boards into this mix as I'm not too clear on whether XD boards are MADE FOR Kprepublic or whether Kprepublic is just selling XD boards.

@zvecr
Copy link
Member Author

zvecr commented Feb 21, 2019

I agree, its a bit ambiguous with a lot of the currently supported boards, vendor vs reseller. Happy to make any changes as required. Figured at least here its a constant thread, instead of it getting lost on discord.

Edit: If a board is only available from one reseller, does it make sense to add it to the resellers keyboard folder? Would this help someone who has purchased from somewhere like KPrepublic find the QMK firmware.

keyboards/kprepublic/cospad/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/cospad/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/daisy/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/daisy/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/jj40/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/jj40/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/jj4x4/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/jj4x4/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/jj50/readme.md Outdated Show resolved Hide resolved
@zvecr zvecr force-pushed the feature/kprepublic_folder branch from 4869b47 to 31c4110 Compare February 22, 2019 00:40
@zvecr
Copy link
Member Author

zvecr commented Feb 22, 2019

@noroadsleft Thanks for digging out all those AliExpress links.

@zvecr
Copy link
Member Author

zvecr commented Feb 23, 2019

I have just noticed that on the kprepublic aliexpress store, the list all the boards as KTEC Series. Would this be a better folder name to use, for the devices it lists?

@noroadsleft
Copy link
Member

I think kprepublic is better to use than ktec_series or a variant, due to name recognition.

@zvecr
Copy link
Member Author

zvecr commented Feb 26, 2019

Waiting on #5219 so not to break programming behaviour, before continuing. Otherwise, i will revert the changes to the VENDOR_ID and PRODUCT_ID (and hopefully reintroduce the change at a later date).

Will update VENDOR_ID and PRODUCT_ID once #5219 so not to break programming behaviour.

@zvecr zvecr force-pushed the feature/kprepublic_folder branch from 31c4110 to 7867f96 Compare March 1, 2019 18:30
@zvecr zvecr force-pushed the feature/kprepublic_folder branch from 7867f96 to 5553e75 Compare March 1, 2019 18:47
@zvecr zvecr marked this pull request as ready for review March 1, 2019 18:49
@GreatWizard
Copy link
Contributor

Doucmentation (and its translations) newbs_flashing.md have a reference to a make command for the jj40 board that must be updated too

@GreatWizard
Copy link
Contributor

GreatWizard commented Jun 29, 2020

Based on my last search, here is the list of the KPrepublic boards:

  • bm16a
  • bm16s
  • bm43a
  • bm60rgb
  • cospad
  • daisy
  • jj4x4
  • jj40
  • jj50
  • staryu
  • xd0002
  • xd0004
  • xd60
  • xd68
  • xd75
  • xd84
  • xd87
  • xd96

@noroadsleft noroadsleft force-pushed the develop branch 2 times, most recently from 550bb6a to 9d827f9 Compare July 31, 2020 19:45
@noroadsleft noroadsleft force-pushed the develop branch 2 times, most recently from 1d4c0cd to 65c27a3 Compare August 29, 2020 21:42
@noroadsleft noroadsleft deleted the branch qmk:develop November 28, 2020 20:02
@tzarc tzarc reopened this Nov 28, 2020
@tzarc tzarc closed this Feb 27, 2021
@tzarc tzarc deleted the branch qmk:develop February 27, 2021 20:27
@noroadsleft noroadsleft reopened this Feb 27, 2021
@zvecr zvecr closed this Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment configurator affects configurator keyboard keymap on hold optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants