Added TGR Alice keyboard support #4896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keyboard uses ps2avrGB firmware, so I used the same matrix Bootmapper Client was using and was able to flash it appropriately.
|
I think this can be probably refactored to eliminate all the custom matrix code and just use the standard QMK core support. Let me take a look at it after work, I'll come up with a version you can test. |
|
@pelrun that’d be amazing. Just let me know and I’ll be glad to retest. |
|
@fcoury thanks for doing this. I started on this task too but I'm currently waiting on the resolution of #4034. Once that is resolved, we'll be able to just put in the pin names like how we do with AVR boards. As of now, the most "correct" way to write the custom matrix code, is as described in the panc60. poking @jackhumbert in regards to the PR above. hint hint, nudge nudge, wink wink. |
drashna
requested changes
Jan 21, 2019
|
I've refactored it (mostly by deleting a lot of it...) so give it a try now: |
drashna
requested changes
Jan 21, 2019
|
@drashna all change requests were addressed AFAIK, let me know otherwise and thanks for your review! |
|
Awesome, thanks! |
|
@pelrun want to fix the default template and other ps2avrgb keyboards, too? :D |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Jan 24, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (87 commits) [Keyboard] KBD67: enable bootmagic lite by default (qmk#4931) [Keymap] Adding keymap for Nyquist (qmk#4918) Optimize/Update the new_project script (qmk#4920) Remove lfkeyboards parent rules.mk as its only required for mini1800 [Keyboard] Add BDN9 (qmk#4919) [Keyboard] Add KBD67 Hotswap Support (qmk#4916) Fixup the clueboard 66 info.json Clueboard refresh (qmk#4902) Give the keymap folder the proper name Fix layouts/default/66_iso keymap [Keyboard] Add DataHand keyboard support (qmk#4847) [Keymap] Add a compile-time provided macro and assign to _FL (qmk#4908) Added info.json for TGR Alice Always read two bytes from the endpoint if we have two bytes to read Rename i2c_slave functions so it can coexist with i2c_master (qmk#4875) Fix for ISO layout in tada68:rys (qmk#4906) [Keyboard] Added TGR Alice keyboard support (qmk#4896) handwired/retro_refit: refactor, Configurator support and readme update (qmk#4899) Initial fixes for vagrant (qmk#4900) Tidy up IS_{,HOST_}LED_{ON,OFF} macros (qmk#4894) ...
tenderlove
added a commit
to tenderlove/qmk_firmware
that referenced
this pull request
Jan 24, 2019
* master: (643 commits) [Keyboard] Remove hadron ver0 as it is no longer required (qmk#4921) Remove unused fn_actions[] and action_function() in default keymaps (qmk#4829) [Keyboard] KBD67: enable bootmagic lite by default (qmk#4931) [Keymap] Adding keymap for Nyquist (qmk#4918) Optimize/Update the new_project script (qmk#4920) Remove lfkeyboards parent rules.mk as its only required for mini1800 [Keyboard] Add BDN9 (qmk#4919) [Keyboard] Add KBD67 Hotswap Support (qmk#4916) Fixup the clueboard 66 info.json Clueboard refresh (qmk#4902) Give the keymap folder the proper name Fix layouts/default/66_iso keymap [Keyboard] Add DataHand keyboard support (qmk#4847) [Keymap] Add a compile-time provided macro and assign to _FL (qmk#4908) Added info.json for TGR Alice Always read two bytes from the endpoint if we have two bytes to read Rename i2c_slave functions so it can coexist with i2c_master (qmk#4875) Fix for ISO layout in tada68:rys (qmk#4906) [Keyboard] Added TGR Alice keyboard support (qmk#4896) handwired/retro_refit: refactor, Configurator support and readme update (qmk#4899) ...
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Feb 2, 2019
* Added TGR Alice keyboard support This keyboard uses ps2avrGB firmware, so I used the same matrix Bootmapper Client was using and was able to flash it appropriately. * Refactor alice to use QMK core * Fixed markdown line breaks on TGR Alice readme
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Added TGR Alice keyboard support This keyboard uses ps2avrGB firmware, so I used the same matrix Bootmapper Client was using and was able to flash it appropriately. * Refactor alice to use QMK core * Fixed markdown line breaks on TGR Alice readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keyboard uses ps2avrGB firmware, so I used the same matrix
Bootmapper Client was using and was able to flash it appropriately.
Description
Added TGR Alice keyboard support
Types of changes
Checklist: