DC60 layout_all not really layout_all #4884

mechmerlin · 2019-01-19T18:15:46Z

Description

Added a missing key to the all layout and actually call it the all layout.

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna · 2019-01-19T18:29:20Z

You forgot to change the default keymap.c. It's erroring out now because LAYOUT no longer exists.

mechmerlin · 2019-01-19T18:31:33Z

Yeah I realized after I PRed, you type too fast.

* add k3c and change layout to LAYOUT_all * fix up info.json for the new layout * forgot to add k3c into the physical layout matrix * fix keymaps

mechmerlin added 2 commits January 19, 2019 10:09

add k3c and change layout to LAYOUT_all

835cc0d

fix up info.json for the new layout

e19dae6

mechmerlin added bug keyboard labels Jan 19, 2019

mechmerlin added 2 commits January 19, 2019 10:30

forgot to add k3c into the physical layout matrix

90e294f

fix keymaps

a8925ef

drashna merged commit 215375f into qmk:master Jan 19, 2019

mechmerlin deleted the feature/dc60_fix branch January 26, 2019 23:54