Add support for Teensy-modified Datahand keyboard #4847

adzenith · 2019-01-14T17:45:32Z

Description

I have a DataHand keyboard in which I've replaced the stock processor with a Teensy++ 2.0 in a similar manner to that described here. This PR adds a new keyboard to support this setup.

Types of changes

Checklist:

My code follows the code style of this project.
I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft

@adzenith My understanding is that changes to core code should be made in pull requests separately from changes or additions to keyboards, but I'll let someone with more knowledge than I make the decision on that.

keyboards/datahand/config.h

keyboards/datahand/datahand.h

keyboards/datahand/keymaps/default/keymap.c

adzenith · 2019-01-14T21:02:19Z

Thanks for the quick review! I've updated the PR as per your suggestions: adding KC_ everywhere, fixing header guards, updating to process_user_record, etc.

drashna

It looks like this may be better in the "converter" folder, given what it is.

That or, because this isn't a mass produced board/replacement controller, it should probably be moved to "handwired".

quantum/matrix.c

tmk_core/common/action_layer.c

adzenith · 2019-01-15T16:09:35Z

I'll move it to handwired. Thanks for the review!

adzenith · 2019-01-15T16:21:35Z

Updated!

adzenith · 2019-01-18T14:26:39Z

CI is showing a strange error: Compiling: keyboards/handwired/datahand/matrix.c avr-gcc: error: device-specs/specs-AT90USB1286: No such file or directory
Does anyone know what this might mean? It builds fine locally.

keyboards/handwired/datahand/rules.mk

adzenith · 2019-01-22T15:07:11Z

Looks like CI is working now! Let me know if there's anything else I need to do. Thanks again for the help!

drashna · 2019-01-22T20:46:15Z

This is more of a nit pick, but could you update the code (especially the default keymap) to conform to the QMK Coding conventions?
https://docs.qmk.fm/#/contributing?id=coding-conventions

adzenith · 2019-01-22T21:17:20Z

Sure! I can change the comments to use C-style comments (which it says is "strongly encouraged") – other than that, I think I already am complying with coding standards. Is there anything else I'm missing?
Thanks!

adzenith · 2019-01-22T21:31:49Z

Updated with C-style comments.

drashna · 2019-01-22T22:05:14Z

The comments are fine.

Mostly: https://github.com/qmk/qmk_firmware/blob/df34c46d1f939ff37fcf24daf94800c65fdeceff/keyboards/handwired/datahand/keymaps/default/keymap.c#L137-L238

And:

https://github.com/qmk/qmk_firmware/blob/df34c46d1f939ff37fcf24daf94800c65fdeceff/keyboards/handwired/datahand/matrix.c

adzenith · 2019-01-22T22:44:52Z

Hm, I'm not sure what you mean. I'm looking at the coding convention and I see

We indent using two spaces (soft tabs)
We use a modified One True Brace Style
We encourage use of C style comments: /* */
In general we don't wrap lines
We use #pragma once

I do see a couple of misplaced braces in keymap.c, which I can fix, but I'm not sure what else is being pointing out in those sections.
Are you referring to the function opening braces? I can move those onto the same lines as the function declarations if so. The coding standard says block braces have to be on the same line, but function braces I wasn't sure about because a different style is used in e.g. quantum/matrix.c and quantum/quantum.c

adzenith · 2019-01-22T22:49:16Z

I've moved the function braces onto the function lines - let me know if that's what you meant!

drashna · 2019-01-22T23:16:41Z

Sorry for not being clear, yeah that's what I meant!

drashna · 2019-01-22T23:17:29Z

Thanks!

adzenith · 2019-01-23T04:25:21Z

Thanks for the reviews and the merge!

* 'master' of https://github.com/qmk/qmk_firmware: (87 commits) [Keyboard] KBD67: enable bootmagic lite by default (qmk#4931) [Keymap] Adding keymap for Nyquist (qmk#4918) Optimize/Update the new_project script (qmk#4920) Remove lfkeyboards parent rules.mk as its only required for mini1800 [Keyboard] Add BDN9 (qmk#4919) [Keyboard] Add KBD67 Hotswap Support (qmk#4916) Fixup the clueboard 66 info.json Clueboard refresh (qmk#4902) Give the keymap folder the proper name Fix layouts/default/66_iso keymap [Keyboard] Add DataHand keyboard support (qmk#4847) [Keymap] Add a compile-time provided macro and assign to _FL (qmk#4908) Added info.json for TGR Alice Always read two bytes from the endpoint if we have two bytes to read Rename i2c_slave functions so it can coexist with i2c_master (qmk#4875) Fix for ISO layout in tada68:rys (qmk#4906) [Keyboard] Added TGR Alice keyboard support (qmk#4896) handwired/retro_refit: refactor, Configurator support and readme update (qmk#4899) Initial fixes for vagrant (qmk#4900) Tidy up IS_{,HOST_}LED_{ON,OFF} macros (qmk#4894) ...

* master: (643 commits) [Keyboard] Remove hadron ver0 as it is no longer required (qmk#4921) Remove unused fn_actions[] and action_function() in default keymaps (qmk#4829) [Keyboard] KBD67: enable bootmagic lite by default (qmk#4931) [Keymap] Adding keymap for Nyquist (qmk#4918) Optimize/Update the new_project script (qmk#4920) Remove lfkeyboards parent rules.mk as its only required for mini1800 [Keyboard] Add BDN9 (qmk#4919) [Keyboard] Add KBD67 Hotswap Support (qmk#4916) Fixup the clueboard 66 info.json Clueboard refresh (qmk#4902) Give the keymap folder the proper name Fix layouts/default/66_iso keymap [Keyboard] Add DataHand keyboard support (qmk#4847) [Keymap] Add a compile-time provided macro and assign to _FL (qmk#4908) Added info.json for TGR Alice Always read two bytes from the endpoint if we have two bytes to read Rename i2c_slave functions so it can coexist with i2c_master (qmk#4875) Fix for ISO layout in tada68:rys (qmk#4906) [Keyboard] Added TGR Alice keyboard support (qmk#4896) handwired/retro_refit: refactor, Configurator support and readme update (qmk#4899) ...

* master: (60 commits) [Keymap] New kbd67/hotswap keymap for writing both code and math (qmk#4933) Add support for Clueboard 66% rev4 Fix a typo in link to the Pro Micro ISP firmware [Keyboard] Remove hadron ver0 as it is no longer required (qmk#4921) Remove unused fn_actions[] and action_function() in default keymaps (qmk#4829) [Keyboard] KBD67: enable bootmagic lite by default (qmk#4931) [Keymap] Adding keymap for Nyquist (qmk#4918) Optimize/Update the new_project script (qmk#4920) Remove lfkeyboards parent rules.mk as its only required for mini1800 [Keyboard] Add BDN9 (qmk#4919) [Keyboard] Add KBD67 Hotswap Support (qmk#4916) Fixup the clueboard 66 info.json Clueboard refresh (qmk#4902) Give the keymap folder the proper name Fix layouts/default/66_iso keymap [Keyboard] Add DataHand keyboard support (qmk#4847) [Keymap] Add a compile-time provided macro and assign to _FL (qmk#4908) Added info.json for TGR Alice Always read two bytes from the endpoint if we have two bytes to read Rename i2c_slave functions so it can coexist with i2c_master (qmk#4875) ...

adzenith force-pushed the datahand branch from 6b16987 to ca4700c Compare January 14, 2019 17:47

noroadsleft requested changes Jan 14, 2019

View reviewed changes

adzenith force-pushed the datahand branch from ca4700c to 37a5279 Compare January 14, 2019 21:00

adzenith force-pushed the datahand branch from 37a5279 to efea09d Compare January 14, 2019 22:15

drashna requested changes Jan 15, 2019

View reviewed changes

quantum/matrix.c Outdated Show resolved Hide resolved

tmk_core/common/action_layer.c Outdated Show resolved Hide resolved

drashna added the keyboard label Jan 15, 2019

adzenith force-pushed the datahand branch from efea09d to 5d5f5e3 Compare January 15, 2019 16:20

adzenith force-pushed the datahand branch 3 times, most recently from 363c102 to e8ebbf1 Compare January 16, 2019 15:41

drashna requested changes Jan 18, 2019

View reviewed changes

keyboards/handwired/datahand/rules.mk Outdated Show resolved Hide resolved

adzenith force-pushed the datahand branch from 3527ee3 to df34c46 Compare January 22, 2019 21:31

Add DataHand keyboard support

69da5db

adzenith force-pushed the datahand branch from df34c46 to 69da5db Compare January 22, 2019 22:49

drashna approved these changes Jan 22, 2019

View reviewed changes

drashna merged commit 6b1009b into qmk:master Jan 22, 2019

adzenith deleted the datahand branch January 23, 2019 04:25

zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Feb 2, 2019

[Keyboard] Add DataHand keyboard support (qmk#4847)

e3d373c

dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019

[Keyboard] Add DataHand keyboard support (qmk#4847)

4e69ffc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Teensy-modified Datahand keyboard #4847

Add support for Teensy-modified Datahand keyboard #4847

adzenith commented Jan 14, 2019 •

edited

Loading

noroadsleft left a comment

adzenith commented Jan 14, 2019

drashna left a comment

adzenith commented Jan 15, 2019

adzenith commented Jan 15, 2019

adzenith commented Jan 18, 2019

adzenith commented Jan 22, 2019

drashna commented Jan 22, 2019

adzenith commented Jan 22, 2019

adzenith commented Jan 22, 2019

drashna commented Jan 22, 2019 •

edited

Loading

adzenith commented Jan 22, 2019

adzenith commented Jan 22, 2019

drashna commented Jan 22, 2019

drashna commented Jan 22, 2019

adzenith commented Jan 23, 2019

Add support for Teensy-modified Datahand keyboard #4847

Add support for Teensy-modified Datahand keyboard #4847

Conversation

adzenith commented Jan 14, 2019 • edited Loading

Description

Types of changes

Checklist:

noroadsleft left a comment

Choose a reason for hiding this comment

adzenith commented Jan 14, 2019

drashna left a comment

Choose a reason for hiding this comment

adzenith commented Jan 15, 2019

adzenith commented Jan 15, 2019

adzenith commented Jan 18, 2019

adzenith commented Jan 22, 2019

drashna commented Jan 22, 2019

adzenith commented Jan 22, 2019

adzenith commented Jan 22, 2019

drashna commented Jan 22, 2019 • edited Loading

adzenith commented Jan 22, 2019

adzenith commented Jan 22, 2019

drashna commented Jan 22, 2019

drashna commented Jan 22, 2019

adzenith commented Jan 23, 2019

adzenith commented Jan 14, 2019 •

edited

Loading

drashna commented Jan 22, 2019 •

edited

Loading