Fix Caps Lock LEDs once and for all #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have two bytes, that probably means the first is a report ID. The 6KRO interface may or may not have one, but the NKRO interface always does, so we need to check this regardless of whether KEYBOARD_SHARED_EP is defined.
fauxpark
changed the title
vomindoraan
reviewed
Jan 11, 2019
|
Works perfectly fine for me on Ubuntu 18.10, with all combinations of |
|
Thanks! |
|
I just came here to say I've been trying way too long to figure out why my caps lock light didn't work (macOS Mojave) and this fixed it like magic. Thanks @fauxpark! |
13 tasks
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
* Check the size of the SET_REPORT packet If we have two bytes, that probably means the first is a report ID. The 6KRO interface may or may not have one, but the NKRO interface always does, so we need to check this regardless of whether KEYBOARD_SHARED_EP is defined. * Fix indentation
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Check the size of the SET_REPORT packet If we have two bytes, that probably means the first is a report ID. The 6KRO interface may or may not have one, but the NKRO interface always does, so we need to check this regardless of whether KEYBOARD_SHARED_EP is defined. * Fix indentation
13 tasks
This was referenced Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The status LEDs don't light up/light up incorrectly on Linux in certain circumstances. This is because, if NKRO is enabled it will send two LED states, one for the 6KRO interface, and one for the NKRO interface. QMK interprets the NKRO report ID as the LED state and turn on the num lock and scroll lock LEDs.
If we have two bytes, that probably means the first is a report ID. The 6KRO interface may or may not have one, but the NKRO interface always does, so we need to check this regardless of whether
KEYBOARD_SHARED_EPis defined.The status LEDs now function correctly on Windows 10, macOS 10.14 and Ubuntu 18.10 under the following conditions:
KEYBOARD_SHARED_EP=no,NKRO_ENABLE=noKEYBOARD_SHARED_EP=no,NKRO_ENABLE=yes, NKRO offKEYBOARD_SHARED_EP=no,NKRO_ENABLE=yes, NKRO onKEYBOARD_SHARED_EP=yes,NKRO_ENABLE=noKEYBOARD_SHARED_EP=yes,NKRO_ENABLE=yes, NKRO offKEYBOARD_SHARED_EP=yes,NKRO_ENABLE=yes, NKRO onTypes of changes
Issues Fixed or Closed by this PR
Checklist: