Added my Prime_O Layout #4811
Merged
Added my Prime_O Layout #4811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mechmerlin
reviewed
Jan 9, 2019
| #define ECTL LCTL_T(KC_ESC) | ||
| #define ALLM ALL_T(KC_MINS) | ||
| #define SCLS LT(3, KC_SCLN) | ||
| #define ______ KC_TRNS |
There was a problem hiding this comment.
If you use 7 spaces instead of 6, you won't need to define this as including QMK_KEYBOARD_H already defines it.
There was a problem hiding this comment.
Should be updated! Thanks!
mechmerlin
approved these changes
Jan 10, 2019
|
Merging this in now. Just a one last note. I noticed you're using your master branch to submit the changes. I would recommend creating a different branch off of master, making your changes there, and submitting through that branch. If on your next QMK submission you continue editing your master branch, you'll run into some issues. Here's a quick summary of some Git basics: http://rogerdudler.github.io/git-guide/ |
rhruiz
pushed a commit
to rhruiz/qmk_firmware
that referenced
this pull request
Jan 11, 2019
* initial prime_o commit * Cleaned up comments, other things. * Update bakingpy 4x12 keymap and add test mode for debugging/development (qmk#4810) * Keymap: ave-63's iris layout (qmk#4812) * Updated keymap to use standard seven-underscore KC_TRNS notation * initial prime_o commit * Cleaned up comments, other things. * Updated keymap to use standard seven-underscore KC_TRNS notation
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
* initial prime_o commit * Cleaned up comments, other things. * Update bakingpy 4x12 keymap and add test mode for debugging/development (qmk#4810) * Keymap: ave-63's iris layout (qmk#4812) * Updated keymap to use standard seven-underscore KC_TRNS notation * initial prime_o commit * Cleaned up comments, other things. * Updated keymap to use standard seven-underscore KC_TRNS notation
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* initial prime_o commit * Cleaned up comments, other things. * Update bakingpy 4x12 keymap and add test mode for debugging/development (qmk#4810) * Keymap: ave-63's iris layout (qmk#4812) * Updated keymap to use standard seven-underscore KC_TRNS notation * initial prime_o commit * Cleaned up comments, other things. * Updated keymap to use standard seven-underscore KC_TRNS notation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just adding in my personal keymap for the Prime_O.
Types of changes
Issues Fixed or Closed by this PR
Checklist: