Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbrero: Configurator fix and code tidy #4787

Merged
merged 2 commits into from
Jan 5, 2019

Conversation

noroadsleft
Copy link
Member

Commit Log

Numbrero: fix Configurator mismatch (a4fb22c)

Key object order in info.json didn't match the layout macro, leading to keys being assigned out-of-sequence.

Numbrero: tidy (f01e4b0)

  • white space changes in numbrero.h (alignment/readability/QMK conventions)
  • minor changes to readme.md (grammar, mostly)

Key object order in info.json didn't match the layout macro, leading to keys being assigned out-of-sequence.
- white space changes in numbrero.h (alignment/readability/QMK conventions)
- minor changes to readme.md (grammar, mostly)
@drashna
Copy link
Member

drashna commented Jan 5, 2019

Thanks!

@drashna drashna merged commit 90046af into qmk:master Jan 5, 2019
@noroadsleft noroadsleft deleted the cf/hw_numbrero branch January 6, 2019 02:52
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jan 10, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (63 commits)
  Keymap: ave-63's iris layout (qmk#4812)
  Update bakingpy 4x12 keymap and add test mode for debugging/development (qmk#4810)
  Fix Mac mute keycode (qmk#4809)
  Add KBD75 keymap (qmk#4808)
  Fix pinout of split hand and LED, remove flip half option
  Tidy up Mod-Tap shortcuts (qmk#4806)
  Add missing parentheses to some important macros (qmk#4775)
  Keyboard: Downbubble refactor and Configurator fix (qmk#4798)
  Alternate keymap for Alpha keyboard, enjoy! (qmk#4797)
  Keymap: Added Model F-inspired layout for YMD[K]96 (qmk#4777)
  Improve consistency in UNICODEMAP code and docs, update docs/understanding_qmk (qmk#4774)
  Update to arm_atsam wait and timer routines
  Add Downbubble to Handwired repository (qmk#4794)
  Final HS60v2 changes. (qmk#4790)
  Keyboard: Fractal layout macro and readme cleanup (qmk#4789)
  Keymap: added my espectro keymap (qmk#4791)
  Keyboard: Numbrero: Configurator fix and code tidy (qmk#4787)
  Keyboard: Tradestation code tidy and readme refactor (qmk#4784)
  Keyboard: update readme with ps2avr flashing instructions (qmk#4776)
  add Pinky keyboard (qmk#4748)
  ...
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
* Numbrero: fix Configurator mismatch

Key object order in info.json didn't match the layout macro, leading to keys being assigned out-of-sequence.

* Numbrero: tidy

- white space changes in numbrero.h (alignment/readability/QMK conventions)
- minor changes to readme.md (grammar, mostly)
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
* Numbrero: fix Configurator mismatch

Key object order in info.json didn't match the layout macro, leading to keys being assigned out-of-sequence.

* Numbrero: tidy

- white space changes in numbrero.h (alignment/readability/QMK conventions)
- minor changes to readme.md (grammar, mostly)
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
* Numbrero: fix Configurator mismatch

Key object order in info.json didn't match the layout macro, leading to keys being assigned out-of-sequence.

* Numbrero: tidy

- white space changes in numbrero.h (alignment/readability/QMK conventions)
- minor changes to readme.md (grammar, mostly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants