Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lily58 update serial.c and add OLED #4715

Merged
merged 4 commits into from
Jan 5, 2019
Merged

Lily58 update serial.c and add OLED #4715

merged 4 commits into from
Jan 5, 2019

Conversation

kata0510
Copy link
Contributor

Description

Update serial.c(from Helix #4278) and Add OLED

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Dec 24, 2018
View reviewed changes
keyboards/lily58/keymaps/yuchi/keymap.c Outdated Show resolved Hide resolved
keyboards/lily58/keymaps/yuchi/keymap.c Outdated Show resolved Hide resolved
@drashna drashna added the keymap label Dec 24, 2018
@kata0510
Copy link
Contributor Author

@drashna
Thank you for review
Fixed the file

drashna
drashna requested changes Jan 2, 2019
View reviewed changes
keyboards/lily58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/lily58/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/lily58/pro_micro.h Outdated Show resolved Hide resolved
@kata0510
Copy link
Contributor Author

kata0510 commented Jan 2, 2019

@drashna
Thank you for review.
I forgot to fix the default keymap.

@drashna
Copy link
Member

drashna commented Jan 5, 2019

You're welcome!

Also, this is more of feedback, but it looks like you're using slightly older helix code here. It may be worth updating that... or even removing the duplicate files, and including the files from the helix folder, specifically.

@drashna drashna added keyboard and removed keymap labels Jan 5, 2019
@drashna drashna merged commit ea47be9 into qmk:master Jan 5, 2019
@kata0510 kata0510 deleted the lily58/dev/oled_serial branch March 13, 2019 07:05
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
@kata0510 @rseymour
Keyboard: Lily58 update serial.c and add OLED (qmk#4715)
a0bba5d 
* update serial.c and add OLED

* update readme

* keymap fix

* keymap fix2
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
@kata0510 @djthread
Keyboard: Lily58 update serial.c and add OLED (qmk#4715)
ac2f710 
* update serial.c and add OLED

* update readme

* keymap fix

* keymap fix2
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@kata0510
Keyboard: Lily58 update serial.c and add OLED (qmk#4715)
be6d6c8 
* update serial.c and add OLED

* update readme

* keymap fix

* keymap fix2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kata0510 @drashna