Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nyquist Rev 3 #4287

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Add Nyquist Rev 3 #4287

merged 2 commits into from
Nov 5, 2018

Conversation

nooges
Copy link
Member

@nooges nooges commented Oct 30, 2018

No description provided.

# automatically (+60). See bootloader.mk for all options.
BOOTLOADER = caterina
ifeq ($(strip $(KEYBOARD)), nyquist/rev3)
BOOTLOADER = dfu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeessss, a decent bootloader.

Can someone actually still put a pro micro in though?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nyquist 3 actually has an on-board controller, so someone would have to go through a considerable effort to put a Pro Micro on there 😄

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, did you want to convert this to the split common code as well?

keyboards/nyquist/rev2/config.h Outdated Show resolved Hide resolved
keyboards/nyquist/rev3/config.h Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Oct 30, 2018

Travis CI errors are unrelated.

Specifically @mtdjr's firmware is 98 bytes over, and @Xyverz's keymap has RGB (ws2812) related issues (from the community layout)
(users tagged for a heads up, and changes aren't necessary)

@nooges
Copy link
Member Author

nooges commented Nov 5, 2018

Converted Nyquist over to split_common

@drashna
Copy link
Member

drashna commented Nov 5, 2018

Thanks!

@drashna drashna merged commit a49d0a1 into qmk:master Nov 5, 2018
@nooges nooges deleted the nyquist-rev3 branch November 6, 2018 20:52
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Nov 17, 2018
* Add Nyquist Rev 3

* Switch to split_common
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
* Add Nyquist Rev 3

* Switch to split_common
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
* Add Nyquist Rev 3

* Switch to split_common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants