Niu keymap WIP #4273
Merged
Niu keymap WIP #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this good to go, right now? |
|
I still have the things to do on the layout once those tasks get marked done. I will be done. |
|
Okay, it looks good as is, so I wanted to make sure. |
|
@drashna go ahead and merge this PR I will put up another PR for the updates. |
|
Awesome, sounds good. :) |
3n4rKy
pushed a commit
to 3n4rKy/qmk_firmware
that referenced
this pull request
Nov 4, 2018
* Add modified planck layout * Update rules
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Nov 10, 2018
* Add modified planck layout * Update rules
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
* Add modified planck layout * Update rules
djthread
pushed a commit
to djthread/qmk_firmware
that referenced
this pull request
Mar 17, 2019
* Add modified planck layout * Update rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to do :