Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for GH60 Satan keyboard #407

Merged
merged 2 commits into from
Jun 14, 2016
Merged

adds support for GH60 Satan keyboard #407

merged 2 commits into from
Jun 14, 2016

Conversation

TerryMathews
Copy link
Contributor

ANSI 125 layout, capslock and backlight implemented, support for WS2812LED strip included
Also adds Satan and Phantom to travis config.

ANSI 125 layout, capslock and backlight implemented, support for
WS2812LED strip included
@jackhumbert
Copy link
Member

Just using up our pr/issue numbers :)

@TerryMathews
Copy link
Contributor Author

Sorry, my skills in C greatly exceed my skills in GitHub. I'm going to have
to sit down and learn the ins and outs of it sometime.

On Mon, Jun 13, 2016 at 9:57 PM, Jack Humbert notifications@github.com
wrote:

Just using up our pr/issue numbers :)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#407 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AB4VBeHUG_PR0QeYwIreps1kbLriMQ2aks5qLgqcgaJpZM4I05LR
.

@jackhumbert jackhumbert merged commit 1c5a673 into qmk:master Jun 14, 2016
@jackhumbert
Copy link
Member

Haha, no worries. Thanks for submitting these! We might move satan into the gh60 eventually - I'm working on that subproject feature, which would be a good fit for that.

@TerryMathews
Copy link
Contributor Author

That'll be nice, especially since there's something like 4 variations of
keymaps the Satan can support and 7 for the Phantom.
On Jun 13, 2016 10:07 PM, "Jack Humbert" notifications@github.com wrote:

Haha, no worries. Thanks for submitting these! We might move satan into
the gh60 eventually - I'm working on that subproject feature, which would
be a good fit for that.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#407 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AB4VBROEevz5-YxDe8CkfVcuywVkAyNnks5qLgzFgaJpZM4I05LR
.

@jackhumbert
Copy link
Member

I didn't even think about the layout variations - in the past we've just done those as KEYMAP macro shortcuts, but they get kind of complicated when there's more than one option.

ryaninvents pushed a commit to ryaninvents/qmk_firmware that referenced this pull request Aug 12, 2016
* adds support for GH60 Satan keyboard

ANSI 125 layout, capslock and backlight implemented, support for
WS2812LED strip included

* added Phantom and GH60 Satan to travis
jiaxin96 pushed a commit to Oh-My-Mechanical-Keyboard/qmk_firmware that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants