Add support for Atmega32A to pin declarations and universal matrix #4015
Conversation
|
@mechmerlin can you test this out on your panc60 when you get the chance? I was getting some weird results with my Atmega32a board, and wanted to make sure I wasn't doing something weird. You should be able to define the pins in the |
There was a problem hiding this comment.
@jackhumbert : I merged your PR locally because we depend on it for #3615 , and also ended up with a weird behaviour : inputs read on A1 would also trigger keys on A2. The highlighted code shows the mistake. Apart from that, everything seems to be working fine. This should allow to remove a whole lot of code duplication amongst keybaords.
edit: btw, i tested on a bminiex, which is a ps2avrGB board using an ATMega32A.
quantum/config_common.h
Outdated
| #ifdef PORTA | ||
| #define A0 PINDEF(A, 0) | ||
| #define A1 PINDEF(A, 1) | ||
| #define A2 PINDEF(A, 1) |
There was a problem hiding this comment.
This line is copy-pasted from the previous one but should apply 2 as the pin instead of 1
|
Just a note: Travis appears to be failing solely because of firmware size errors. Rebasing/merging would fix this issue, as this branch doesn't include the changes to fix those. |
…mk#4015) * add computed pins from mcu type * update for atmega32a * doc typo * add atmega16 chips, link to references * remove avr include from config * exclude assembler in config.h includes * consolodate options, add 646 * fix typo in pindef
…mk#4015) * add computed pins from mcu type * update for atmega32a * doc typo * add atmega16 chips, link to references * remove avr include from config * exclude assembler in config.h includes * consolodate options, add 646 * fix typo in pindef
…mk#4015) * add computed pins from mcu type * update for atmega32a * doc typo * add atmega16 chips, link to references * remove avr include from config * exclude assembler in config.h includes * consolodate options, add 646 * fix typo in pindef
…mk#4015) * add computed pins from mcu type * update for atmega32a * doc typo * add atmega16 chips, link to references * remove avr include from config * exclude assembler in config.h includes * consolodate options, add 646 * fix typo in pindef
No description provided.