Add german layout for redox keyboard #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A german layout for the redox keyboard which tries
to stay close to the default english redox layout
while acommodating the umlauts at their usual position.
drashna
requested changes
Aug 19, 2018
| along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #ifndef CONFIG_USER_H |
There was a problem hiding this comment.
Could you replace this line, and the next 3 lines (up to and including the "include") with just #pragma once, and remove the endifat the end
| @@ -0,0 +1,5 @@ | |||
| RGBLIGHT_ENABLE = yes | |||
|
|
|||
| ifndef QUANTUM_DIR | |||
There was a problem hiding this comment.
Do you mean that the RGBLIGHT_ENABLE = yes is the default value? I cannot test this since my redox does not have any lightning. (I just tried to preserve the behavior of the default keymap.).
Should I also change the two other redox keymaps accordingly while I am at it?
There was a problem hiding this comment.
No, that's fine. The ifndef QUANTUM_DIR stuff. That line and the two after it, as well.
The keycode for Y was wrong.
* Remove #ifdef include guard by #pragma once * Remove unnecessary include from rules.mk
|
@drashna I have added the requested changes. |
drashna
approved these changes
Aug 25, 2018
drashna
requested changes
Aug 25, 2018
|
|
||
| #pragma once | ||
|
|
||
| #include "../../config.h" |
There was a problem hiding this comment.
This line isn't needed. All relevant config.h files are included by default.
|
|
||
| }; | ||
|
|
||
| #ifdef AUDIO_ENABLE |
There was a problem hiding this comment.
It looks like this line and everything below it isn't needed, actually.
|
@drashna I have made the requested changes |
drashna
approved these changes
Aug 29, 2018
|
Awesome, looks good! |
|
Thanks for the review! |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Aug 31, 2018
* 'master' of https://github.com/qmk/qmk_firmware: (73 commits) Keymap: Updated keymap with the "pretty" layout (qmk#3812) Keyboard: CTRL and ALT updates (qmk#3810) Docs: Tabulate Modifier & Mod-Tap keycode listings in advanced keycodes docs (qmk#3799) Keymap: Wanleg updates (qmk#3794) Keymap: Added new tada68 keymap (qmk#3788) Tweak the wording in "Becoming a QMK Collaborator" Docs: add process_terminal() and update links to other functions (qmk#3778) Keymap: Update keymap including LAYOUT_planck_grid (qmk#3779) Keyboard: remove old comment from keyboards/helix/rules.mk (qmk#3795) Keyboard: Update CTRL and ALT keyboard readme (qmk#3796) Mask off keycode/layer/mod where possible in LT(), MT(), etc. (qmk#3430) Autodetect lack of screen presence Massdrop keyboards readme update (qmk#3791) move massdrop boards into its own directory for configurator visibility STM32 EEPROM Emulation (qmk#3741) Massdrop keyboard support (qmk#3780) Keymap: Add german layout for redox keyboard (qmk#3695) Keyboard: Adding the AT101 PCB (qmk#3785) Updated templates for use by new_project.sh (qmk#3783) Fixed bootloader target Fixed matching grep matches (for PRODUCT in particular) Fixed " Bootloader" concatenation for WSL (windows line-endings) ...
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Sep 6, 2018
* Add german layout for redox keyboard
A german layout for the redox keyboard which tries
to stay close to the default english redox layout
while acommodating the umlauts at their usual position.
* Fix keycodes in german redox keymap
The keycode for Y was wrong.
* Minor changes
* Remove #ifdef include guard by #pragma once
* Remove unnecessary include from rules.mk
* Review changes
Remove unnecessary code fragments that
were pointed out in the review
of PR qmk#3695 by @drashna.
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* Add german layout for redox keyboard
A german layout for the redox keyboard which tries
to stay close to the default english redox layout
while acommodating the umlauts at their usual position.
* Fix keycodes in german redox keymap
The keycode for Y was wrong.
* Minor changes
* Remove #ifdef include guard by #pragma once
* Remove unnecessary include from rules.mk
* Review changes
Remove unnecessary code fragments that
were pointed out in the review
of PR qmk#3695 by @drashna.
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Add german layout for redox keyboard
A german layout for the redox keyboard which tries
to stay close to the default english redox layout
while acommodating the umlauts at their usual position.
* Fix keycodes in german redox keymap
The keycode for Y was wrong.
* Minor changes
* Remove #ifdef include guard by #pragma once
* Remove unnecessary include from rules.mk
* Review changes
Remove unnecessary code fragments that
were pointed out in the review
of PR qmk#3695 by @drashna.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A german layout for the redox keyboard which tries
to stay close to the default english redox layout
while acommodating the umlauts at their usual position.