Fixed MxSS ISO layouts in QMK configuator (hopefully) #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than RGB Added code for LED state change on layer change
Updated name in license descriptions Updated layouts to snake case Corrected mistakes in info.json Updated layer_colors to a weak attributed array in mxss.c
Fixed LEDs not always updating in indicator mode Added support for the other RGBLIGHT modes in RGB mode
|
Thanks! |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Jul 27, 2018
* Attempted fix for ISO layouts for QMK configurator * Updated MxSS ISO layouts to remove an unnecessary key
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* Attempted fix for ISO layouts for QMK configurator * Updated MxSS ISO layouts to remove an unnecessary key
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Attempted fix for ISO layouts for QMK configurator * Updated MxSS ISO layouts to remove an unnecessary key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My third attempt at a fix for ISO layouts in the configurator, last issue was caused by an unexpected key I left in the keymap.