-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add corne keyboard #3119
Add corne keyboard #3119
Conversation
Can you explain what your keylogger file is supposed to do? =P |
#define KC_ALTKN ALT_T(KC_LANG1) | ||
|
||
const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
[_QWERTY] = KEYMAP_kc( \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change all instances of the KEYMAP_kc
macro to LAYOUT_kc
keyboards/crkbd/rev1/rev1.h
Outdated
#endif | ||
|
||
//void promicro_bootloader_jmp(bool program); | ||
#define KEYMAP( \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change all instances of the KEYMAP
macro to LAYOUT
#include <stdbool.h> | ||
#include "serial.h" | ||
|
||
#ifdef USE_SERIAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be #ifndef USE_I2C
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file includes logic code for serial only.
Why cheking the flag of I2C here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, well, the consideration was for the configurator. With it set like this, it most likely won't compile.
@mechmerlin looks like the keylogger prints the keystrokes to the screen. |
@mechmerlin @drashna Thank you reviews! Fixed some code and commented. |
Thanks! |
* Fork from helix * Move rev2 to rev1 * Remove unused settings * Move split_util to outof rev * Setup KEYMAP for crkbd * Remove old image * Move keymaps directory and glcdfont.c * Remove AUDIO in keymap * Show keylog * Show keylogs * Show time log * Remove EISU/KANA * Use KEYMAP_kc * Remove iota_gfx_record_user wrapping * Remove unused settings for layer * Add keylogger.c * Fix uppercase letters to lower * Add timelogger.c * Default RGBLED_NUM = 27 * Remove unused setting * Add mode icon reader * Add matrix_write_ln * Add layer_state_reader * Move to lib directory * Rename functions * Add host_led_state_reader * Add logo_reader * Cleaning of iota_gfx_task * Fix bugs and add key defines * Remove unnecessary comments * Update crkbd readme * Move libs to lib directories * Rename KEYMAP to LAYOUT
I designed a new keyboard.
Corne keyboard(crkbd), a split keyboard with 3x6 vertically staggered keys and 3 thumb keys.