Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YMDK NP21 keyboard to use proper keyboard level functions #3042

Merged
merged 4 commits into from
Oct 1, 2018

Conversation

drashna
Copy link
Member

@drashna drashna commented May 24, 2018

It's using the _user functions in the KB code, and doesn't allow for user customization.

@drashna drashna closed this May 25, 2018
@drashna
Copy link
Member Author

drashna commented May 25, 2018

More complicated than I thought.
It's using _user functions, because it's run out of the normal "built in" ones.

Will fix later, as it needs a good amount of work

@drashna drashna changed the title Fix YMDK NP21 keyboard to use proper keyboard level functions [WIP] Fix YMDK NP21 keyboard to use proper keyboard level functions May 25, 2018
@drashna drashna reopened this May 25, 2018
@drashna drashna changed the title [WIP] Fix YMDK NP21 keyboard to use proper keyboard level functions Fix YMDK NP21 keyboard to use proper keyboard level functions May 25, 2018
@drashna drashna force-pushed the ymdk_fix branch 3 times, most recently from 8b1cde1 to 5b4d516 Compare June 1, 2018 05:45
@drashna drashna force-pushed the ymdk_fix branch 2 times, most recently from d8d63e7 to 8dbd8a8 Compare July 5, 2018 04:49
@jackhumbert
Copy link
Member

Awesome - thanks :)

zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Oct 13, 2018
* Use proper function levels

* Add matrix init functions

* Convert KEYMAP to LAYOUT

Or @mechmerlin is going to hunt me down and harm me... probably :)

* Fix conflict issues
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
* Use proper function levels

* Add matrix init functions

* Convert KEYMAP to LAYOUT

Or @mechmerlin is going to hunt me down and harm me... probably :)

* Fix conflict issues
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
* Use proper function levels

* Add matrix init functions

* Convert KEYMAP to LAYOUT

Or @mechmerlin is going to hunt me down and harm me... probably :)

* Fix conflict issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants