Refactor for Alps64 #3029
Merged
Refactor for Alps64 #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync operation
Sync operation
|
A procedural question @drashna (who will probably be the one reviewing this): Have my PRs today been manageable/well documented? Anything I could do better? |
mechmerlin
reviewed
May 23, 2018
keyboards/alps64/alps64.h
Outdated
| @@ -106,21 +106,4 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| { K70, K71, K72, K73, K74, K75, K76, K77 } \ | |||
| } | |||
|
|
|||
| #define LAYOUT_kc( \ | |||
There was a problem hiding this comment.
I am not in favor of removing the LAYOUT_kc macro as people do find this useful.
It's fine that we made LAYOUT_all the macro used by the default keymap, but we should keep LAYOUT_kc
|
While you're refactoring this, it would be great to change LAYOUT_standard_60 to LAYOUT_60_ansi |
|
You may also want to put a |
|
looks good! |
|
Thanks! |
carlpehrson
pushed a commit
to carlpehrson/qmk_firmware
that referenced
this pull request
May 30, 2018
* Refactor for Alps64 * Reverts deletion of LAYOUT_kc macro; renames LAYOUT_standard_60 to LAYOUT_60_ansi * Add LAYOUTS = 60_ansi to rules.mk * Rename LAYOUT_standard_60 to LAYOUT_60_ansi in info.json
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Refactor for Alps64 * Reverts deletion of LAYOUT_kc macro; renames LAYOUT_standard_60 to LAYOUT_60_ansi * Add LAYOUTS = 60_ansi to rules.mk * Rename LAYOUT_standard_60 to LAYOUT_60_ansi in info.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
keyboards/alps64/:LAYOUT_kcmacro fromalps64.hkeymaps/default/keymap.cto useLAYOUT_allmacro