Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UT47 matrix #2824

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Fix UT47 matrix #2824

merged 2 commits into from
Apr 27, 2018

Conversation

drashna
Copy link
Member

@drashna drashna commented Apr 27, 2018

No description provided.

@drashna drashna requested a review from jackhumbert April 27, 2018 15:54
Copy link
Contributor

@filoxo filoxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this one! Its interesting because I've had 2 others test this before and neither reported this issue. I'm going to test this fix later today as well, see if it works on the default layout; I don't anticipate any problems.

@drashna
Copy link
Member Author

drashna commented Apr 27, 2018

Yeah, the k35 is in the wrong spot. That's the issue.

However, if both are needed, then that should be fine. Can add both.

@drashna drashna merged commit 376a384 into qmk:master Apr 27, 2018
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request May 2, 2018
* 'master' of https://github.com/Shinichi-Ohki/qmk_firmware: (34 commits)
  スレーブとマスタの設定直した。
  通信用ポートを設定してみたが通信できてないもよう
  通信ポート設定、入出力ピンを変えた通信対応
  My userspace and lets_split keymap (qmk#2842)
  Redox keyboard code (qmk#2843)
  キーマップ修正 Visual Studio Codeを使ったらソースが整形されてしまった
  Add dz60 iso layout with vim-style arrows (qmk#2837)
  Fix Clicky Down code
  Addkeymap/tada fakb (qmk#2830)
  Add knops mini info json and implemented latest QMK standards (qmk#2832)
  Add RGB keymap to UT47 (qmk#2826)
  QMK Configurator updates to Tada68 (qmk#2825)
  Add keymap diagram (qmk#2819)
  QMK Configurator updates for Mechmini v2 (qmk#2820)
  QMK Configurator Support (qmk#2821)
  QMK Configurator Support for HHKB and Staryu (qmk#2823)
  Fix UT47 matrix (qmk#2824)
  Updated tri-layer block in keymap file. (qmk#2827)
  Add missing 7U and 4U layouts to 2x1800 (qmk#2829)
  New Numpad Support: naKey from ckeys.org (qmk#2828)
  ...
carlpehrson pushed a commit to carlpehrson/qmk_firmware that referenced this pull request May 7, 2018
* Fix UT47 matrix

* Use both spots in the matrix for the space bar
@drashna drashna deleted the ut47 branch May 9, 2018 00:53
akatrevorjay added a commit to akatrevorjay/qmk_firmware that referenced this pull request Oct 8, 2018
* 'master' of git://github.com/qmk/qmk_firmware: (105 commits)
  Add dz60 iso layout with vim-style arrows (qmk#2837)
  Fix Clicky Down code
  Addkeymap/tada fakb (qmk#2830)
  Add knops mini info json and implemented latest QMK standards (qmk#2832)
  Add RGB keymap to UT47 (qmk#2826)
  QMK Configurator updates to Tada68 (qmk#2825)
  Add keymap diagram (qmk#2819)
  QMK Configurator updates for Mechmini v2 (qmk#2820)
  QMK Configurator Support (qmk#2821)
  QMK Configurator Support for HHKB and Staryu (qmk#2823)
  Fix UT47 matrix (qmk#2824)
  Updated tri-layer block in keymap file. (qmk#2827)
  Add missing 7U and 4U layouts to 2x1800 (qmk#2829)
  New Numpad Support: naKey from ckeys.org (qmk#2828)
  Bring dactyl/matrix.c in line with quantum/matrix.c (qmk#2613)
  FC660C Configurator Support (qmk#2817)
  avocado toast change (qmk#2816)
  QMK Configurator Support MF68 (qmk#2815)
  More QMK Configurator Support for Pearl (qmk#2814)
  Keymap Fixes for 7U layout, RGB and Audio support (qmk#2779)
  ...
hauleth pushed a commit to hauleth/qmk_firmware that referenced this pull request Jan 24, 2019
* Fix UT47 matrix

* Use both spots in the matrix for the space bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants