Add new keyboard "Left Slinger" #24618
Conversation
|
@drashna Can you please review this PR? |
There was a problem hiding this comment.
Is there a specific reason for this custom code over using the core analog joystick driver?
This is simpler, yes, but loses out on some of the improvements that the core has.
There was a problem hiding this comment.
https://x.com/takashicompany/status/1742946762447573352
The joystick on this keyboard was incompatible with the QMK Firmware joystick implementation, and the pointer movement was linear in response to stick input. My implementation is at least compatible with the joystick that will be installed, so I wrote the source code separately.
| } | ||
|
|
||
| // クリック用のレイヤーを有効にする。 Enable layers for clicks | ||
| void enable_click_layer(void) { |
There was a problem hiding this comment.
This seems to be a re-implementation of the pointing device auto mouse layer feature.
There was a problem hiding this comment.
The implementation is certainly close to Automatic Mouse Layer. However, I would like to use this source code if it is not a problem, as I would like to make modifications suitable for keyboards in the future. Please consider this.
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Description
I have designed a new keyboard and would appreciate a review.
Types of Changes
Issues Fixed or Closed by This PR
Checklist