Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add SIRIND Brick65S #24315

Merged
merged 6 commits into from
Dec 24, 2024
Merged

[Keyboard] Add SIRIND Brick65S #24315

merged 6 commits into from
Dec 24, 2024

Conversation

eerraa
Copy link
Contributor

@eerraa eerraa commented Aug 23, 2024

Add SIRIND Brick65S

Description

I would like to add SIRIND's Brick65S PCB.
This PCB is the solder version of Brick65.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

eerraa added 2 commits August 23, 2024 12:06
@eerraa
Add Brick65S
342eb69 
Add Brick65S
@eerraa
Update
ae37b00 
Update
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 23, 2024
zvecr
zvecr requested changes Aug 24, 2024
View reviewed changes
keyboards/era/sirind/brick65s/keyboard.json Outdated Show resolved Hide resolved
keyboards/era/sirind/brick65s/keyboard.json Outdated Show resolved Hide resolved
eerraa and others added 2 commits August 24, 2024 22:36
@eerraa @zvecr
Update keyboards/era/sirind/brick65s/keyboard.json
f595539 
Co-authored-by: Joel Challis <git@zvecr.com>
@eerraa @zvecr
Update keyboards/era/sirind/brick65s/keyboard.json
6471512 
Co-authored-by: Joel Challis <git@zvecr.com>
@eerraa eerraa requested a review from zvecr September 22, 2024 07:15
@eerraa
Remove via keymap
1d86b0e 
Remove via keymap
@eerraa
Copy link
Contributor Author

eerraa commented Sep 27, 2024 •
edited
Loading

@dunk2k @drashna @waffle87
Good day, sir.
If there's a reason why this PR merger isn't going on, may I know?
If you let me know, I'll revise it.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 12, 2024
@eerraa
Update
25a6f5b 
Update
@waffle87 waffle87 requested a review from a team November 12, 2024 06:08
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 13, 2024
@drashna drashna merged commit 18f0d11 into qmk:master Dec 24, 2024
3 checks passed
@eerraa eerraa mentioned this pull request Dec 24, 2024
Open
4 tasks
dpnetca pushed a commit to dpnetca/qmk_firmware that referenced this pull request Dec 24, 2024
@eerraa @zvecr
[Keyboard] Add SIRIND Brick65S (qmk#24315)
baeb666 
Co-authored-by: Joel Challis <git@zvecr.com>
haxwagon pushed a commit to haxwagon/qmk_firmware that referenced this pull request Jan 3, 2025
@eerraa @zvecr @haxwagon
[Keyboard] Add SIRIND Brick65S (qmk#24315)
eaf9d7a 
Co-authored-by: Joel Challis <git@zvecr.com>
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@eerraa @zvecr @LeonMusCoden
[Keyboard] Add SIRIND Brick65S (qmk#24315)
6e8ac3f 
Co-authored-by: Joel Challis <git@zvecr.com>
ichichou pushed a commit to ichichou/qmk_firmware that referenced this pull request Jan 8, 2025
@eerraa @zvecr @ichichou
[Keyboard] Add SIRIND Brick65S (qmk#24315)
fbb2106 
Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eerraa @drashna @zvecr @waffle87