Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cu24 keyboard addition #2330

Merged
merged 17 commits into from
Feb 3, 2018
Merged

Cu24 keyboard addition #2330

merged 17 commits into from
Feb 3, 2018

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Feb 1, 2018

Addition of a new keyboard. Announcement can be found here and it will be sold by CapUnlocked.

Production is expected at the end of the month!

@jackhumbert
Copy link
Member

Awesome! Would you mind making the folder/filenames lowercase? We try to keep all the keyboards standardised like that :)

@yiancar
Copy link
Contributor Author

yiancar commented Feb 1, 2018

Done!

.gitignore Outdated
@@ -65,3 +65,4 @@ util/Win_Check_Output.txt
secrets.tar
id_rsa_*
/.vs
lib/chibios-contrib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you having trouble with this? Our make git-submodule should be able to fix it. We need to be able to track changes to that folder :)

Copy link
Contributor Author

@yiancar yiancar Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submodules are synced but there is nothing new to git add so i cannot recommit :S tried a merge with the upstream if that helps

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Can you remove this line then? Just meant tracking changes in general, not with this specific PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is embarrassing. I just realized what the issue was:)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be ok now:)

@jackhumbert jackhumbert merged commit 8350d7e into qmk:master Feb 3, 2018
@jackhumbert
Copy link
Member

Perfect :) thanks!

@yiancar yiancar deleted the cu24 branch February 3, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants