Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for make test:all DEBUG=1 #23047

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Workaround for make test:all DEBUG=1 #23047

merged 2 commits into from
Feb 16, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 10, 2024 •
edited
Loading

Description

Should address the keyboard level issues seen in 23041.

Compiling: quantum/quantum.c                                                                       In file included from quantum/quantum.h:54,
                 from quantum/quantum.c:17:
quantum/logging/debug.h:58:9: error: expected identifier or ‘(’ before ‘do’
   58 |         do {                                                      \
      |         ^~
quantum/logging/debug.h:60:11: error: expected identifier or ‘(’ before ‘while’
   60 |         } while (0)
      |           ^~~~~
quantum/logging/debug.h:58:9: error: expected identifier or ‘(’ before ‘do’
   58 |         do {                                                      \
      |         ^~
quantum/logging/debug.h:60:11: error: expected identifier or ‘(’ before ‘while’
   60 |         } while (0)
      |           ^~~~~
 [ERRORS]
 | 
 | 
 | 
make[1]: *** [builddefs/common_rules.mk:373: .build/test_obj/basic/quantum/quantum.o] Error 1

Longer term the plan is to rework logging to remove dprintf.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 10, 2024
@zvecr zvecr added the bug label Feb 10, 2024
@DavidSannier
Copy link
Contributor

Hello Joel,
Thanks for this fix.
It is not exactly in the same area, but I have another comment about this DEBUG=1:
As this DEBUG value is used with CFLAGS += -g$(DEBUG) in common_rules.mk, it could also be set to 2 or 3, but in build_test.mk, it is only compared to 1 (meaning that CONSOLE_ENABLE won't be set for those values).
Regards

@drashna drashna requested a review from a team February 12, 2024 00:40
@zvecr zvecr changed the title Fix make test:all DEBUG=1 Workaround for make test:all DEBUG=1 Feb 16, 2024
@zvecr zvecr merged commit 6890c1a into develop Feb 16, 2024
4 checks passed
@zvecr zvecr deleted the fix_make_test_debug branch February 16, 2024 09:54
@zvecr
Copy link
Member Author

zvecr commented Feb 16, 2024

It is not exactly in the same area, but I have another comment about this DEBUG=1:
As this DEBUG value is used with CFLAGS += -g$(DEBUG) in common_rules.mk, it could also be set to 2 or 3, but in build_test.mk, it is only compared to 1 (meaning that CONSOLE_ENABLE won't be set for those values).

Looks like an oversight. Feel free to raise a PR to address the issue.

@DavidSannier
Copy link
Contributor

#23097

nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Workaround for make test:all DEBUG=1 (qmk#23047)
98496d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @DavidSannier @drashna