Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Prepare for SyntaxWarning #22562

Merged
merged 3 commits into from
Feb 16, 2024
Merged

[Enhancement] Prepare for SyntaxWarning #22562

merged 3 commits into from
Feb 16, 2024

Conversation

elpekenin
Copy link
Contributor

@elpekenin elpekenin commented Nov 28, 2023 •
edited
Loading

Description

Is not really an issue yet, but invalid escape sequences, eg '\[' will throw a SyntaxWarning on newer versions of Python. To avoid them i've looked through lib/python and fixed the faulty ones i could find.

Used git diff to check the output of both changes and didn't seem to affect functionality.

PS: Saw a couple places with stuff like '\\\\' which could become r'\\', but decided not to make more changes than strictly needed.

PS2: Bux could've been fixed by '\B' -> '\\B' but i decided to make it a r"" to change the '\\"' and get the right border to align

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Nov 28, 2023
@drashna drashna requested a review from a team November 29, 2023 00:33
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 13, 2024
@zvecr zvecr added awaiting review breaking_change_2024q1 and removed stale Issues or pull requests that have become inactive without resolution. labels Jan 27, 2024
@elpekenin
Copy link
Contributor Author

elpekenin commented Feb 7, 2024 •
edited
Loading

Busy week + internet was down for most part of it. Sorry for the delay

I think i've fixed everything now, running a diff is a bit painful because the build_log changing from a run to the next, but seems like the output makefile is indeed identical other than that 👍

@tzarc tzarc requested review from zvecr and a team February 16, 2024 14:33
@zvecr zvecr merged commit 9b0b3d7 into qmk:develop Feb 16, 2024
5 checks passed
@elpekenin elpekenin deleted the fix/r-strings branch February 16, 2024 14:35
@zvecr zvecr mentioned this pull request Mar 21, 2024
Closed
2 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@elpekenin @nuess0r
[Enhancement] Prepare for SyntaxWarning (qmk#22562)
162f79a
@Swiftb0y Swiftb0y mentioned this pull request Sep 19, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
awaiting review cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elpekenin @tzarc @zvecr