Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 speed mousekey movement #2246

Merged
merged 9 commits into from
Mar 27, 2019
Merged

3 speed mousekey movement #2246

merged 9 commits into from
Mar 27, 2019

Conversation

JonArintok
Copy link
Contributor

With these modifications to mousekey.c and mousekey.h, the cursor and scrolling will now move at a constant speed. 3 speeds can be precisely defined for both the cursor and the mouse wheel in your keymap's config.h. I also updated the docs accordingly.

@Markus00000
Copy link
Contributor

I suggest making the constant speeds an optional feature. People who have been using acceleration might not be happy when it is removed and their mouse suddenly moves at constant speeds only.

@JonArintok
Copy link
Contributor Author

OK, I'm working on a solution.

@JonArintok
Copy link
Contributor Author

JonArintok commented Jan 9, 2018

With this, the original behavior will be unchanged, and there should be no performance penalty either way.

@drashna
Copy link
Member

drashna commented May 14, 2018

There is a doc conflict

@DanielGGordon
Copy link
Contributor

I personally use and enjoy having acceleration. I would not want constant speed to be default.

@drashna drashna requested a review from fredizzimo January 25, 2019 19:05
@drashna drashna requested review from ezuk, mechmerlin and yanfali March 21, 2019 23:29
@drashna
Copy link
Member

drashna commented Mar 21, 2019

@DanielGGordon it looks like this PR actually allows for both acceleration, or a set speed. So you can choose when compiling.

@drashna drashna merged commit 346cbd8 into qmk:master Mar 27, 2019
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
This allows for constant, non-accelerated mouse movement, while retaining the original functionality. Configurable by a define.
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 28, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (75 commits)
  [Keyboard] E6V2 Bootmapper Client QMK port (qmk#5495)
  [Keymap] Add kwer keymap and RGB mod description to cypher (qmk#5479)
  [Keymap] added user keymap (qmk#5499)
  build size-check enhancement (qmk#5485)
  [Keyboard] Add Collide39 keyboard (qmk#5486)
  [Docs] Add udev rule for Input Club bootloaders (qmk#5494)
  [Keymap] adding keymaps (qmk#3583)
  Add 3 speed mousekey movement option (qmk#2246)
  [Keymap] add redox/rev1:fculpo keymap (qmk#5491)
  [Keymap] Update iris default (qmk#5489)
  Refactor staryu to current standards and enable support for backlight keycodes (qmk#5487)
  Fixing Ergodox_EZ rgb_led initialization
  Added songs from Nier and Nier Automata
  Document an annoyance with Grave Escape and macOS Terminal (qmk#5483)
  Bugfix for recently integrated cypher keyboard (qmk#5481)
  add keyboards/mxss/rgblight.h from e661f15:quantum/rgblight.h (qmk#5461)
  [Keymap] Planck Keymap :: rjhiglefort (qmk#5059)
  Add support for RGB LEDs wired directly to each half's controller (qmk#5392)
  [Keyboard] added cypher keyboard support (qmk#5466)
  [Keymap] Add custom Planck Light keymap (qmk#5464)
  ...
danielo515 pushed a commit to danielo515/qmk_firmware that referenced this pull request May 15, 2019
This allows for constant, non-accelerated mouse movement, while retaining the original functionality. Configurable by a define.
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
This allows for constant, non-accelerated mouse movement, while retaining the original functionality. Configurable by a define.
@zk-phi zk-phi mentioned this pull request Jul 30, 2019
13 tasks
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Nov 26, 2019
This allows for constant, non-accelerated mouse movement, while retaining the original functionality. Configurable by a define.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants