Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard]add mod007_v3 keyboard. #21198

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

[Keyboard]add mod007_v3 keyboard. #21198

wants to merge 48 commits into from

Conversation

jonylee1986
Copy link
Contributor

Description

as title.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 10, 2023
waffle87
waffle87 requested changes Jun 10, 2023
View reviewed changes
keyboards/akko/mod007_v3/config.h Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/info.json Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/keymaps/via/keymap.c Outdated Show resolved Hide resolved
jonylee1986 and others added 7 commits June 12, 2023 11:36
@jonylee1986 @waffle87
Update keyboards/akko/mod007_v3/config.h
eaaef99 
Co-authored-by: jack <0x6a73@protonmail.com>
@jonylee1986 @waffle87
Update keyboards/akko/mod007_v3/info.json
253528e 
Co-authored-by: jack <0x6a73@protonmail.com>
@jonylee1986 @waffle87
Update keyboards/akko/mod007_v3/keymaps/default/keymap.c
236e934 
Co-authored-by: jack <0x6a73@protonmail.com>
@jonylee1986 @waffle87
Update keyboards/akko/mod007_v3/keymaps/via/keymap.c
c608f65 
Co-authored-by: jack <0x6a73@protonmail.com>
@jonylee1986 @waffle87
Update keyboards/akko/mod007_v3/keymaps/default/keymap.c
b8372fa 
Co-authored-by: jack <0x6a73@protonmail.com>
@jonylee1986 @waffle87
Update keyboards/akko/mod007_v3/keymaps/via/keymap.c
70ebb09 
Co-authored-by: jack <0x6a73@protonmail.com>
@jonylee1986
add keymap/default/rules.mk
b02fb95
@jonylee1986 jonylee1986 requested a review from waffle87 June 12, 2023 03:50
@jonylee1986 jonylee1986 requested a review from drashna June 14, 2023 02:00
lesshonor
lesshonor suggested changes Jun 14, 2023
View reviewed changes
keyboards/akko/mod007_v3/readme.md Outdated Show resolved Hide resolved
@jonylee1986 @lesshonor
Update keyboards/akko/mod007_v3/readme.md
b2a14fe 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@jonylee1986 jonylee1986 requested a review from lesshonor June 15, 2023 02:25
lesshonor
lesshonor approved these changes Jun 15, 2023
View reviewed changes
keyboards/akko/mod007_v3/info.json Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Sep 18, 2023
View reviewed changes
keyboards/akko/mod007_v3/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
jonylee1986 and others added 2 commits September 18, 2023 12:20
@jonylee1986 @fauxpark
Update keyboards/akko/mod007_v3/keymaps/via/keymap.c
84178a1 
Co-authored-by: Ryan <fauxpark@gmail.com>
@jonylee1986 @fauxpark
Update keyboards/akko/mod007_v3/keymaps/default/keymap.c
3a81358 
Co-authored-by: Ryan <fauxpark@gmail.com>
drashna
drashna requested changes Sep 23, 2023
View reviewed changes
keyboards/akko/mod007_v3/mod007_v3.c Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/config.h Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/info.json Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/akko/mod007_v3/keymaps/via/keymap.c Outdated Show resolved Hide resolved
jonylee1986 and others added 3 commits September 27, 2023 10:40
@jonylee1986 @drashna
Update keyboards/akko/mod007_v3/config.h
4b95eec 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@jonylee1986 @drashna
Update keyboards/akko/mod007_v3/info.json
704d490 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@jonylee1986
Update keymap.c
052a360 
replace the tabs with spaces
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 8, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label May 16, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 21, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jul 24, 2024
@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 6, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 13, 2024
drashna
drashna requested changes Nov 30, 2024
View reviewed changes
keyboards/akko/mod007_v3/mod007_v3.c Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/akko/mod007_v3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 15, 2025
jonylee1986 and others added 3 commits January 15, 2025 17:35
@jonylee1986 @drashna
Update keyboards/akko/mod007_v3/mod007_v3.c
e1ddef5 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@jonylee1986 @drashna
Update keyboards/akko/mod007_v3/keymaps/default/keymap.c
b26acc1 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@jonylee1986 @drashna
Update keyboards/akko/mod007_v3/keymaps/default/keymap.c
f58612e 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor requested changes

@zvecr zvecr zvecr requested changes

@drashna drashna drashna requested changes

@waffle87 waffle87 Awaiting requested review from waffle87

@fauxpark fauxpark Awaiting requested review from fauxpark

@adophoxia adophoxia Awaiting requested review from adophoxia

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jonylee1986 @tzarc @drashna @fauxpark @zvecr @waffle87 @lesshonor @adophoxia