Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ez_maker/directpins/promicro: Fix bootloader mismatch #20627

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

sigprof
Copy link
Contributor

@sigprof sigprof commented Apr 29, 2023

Description

The configuration for the ez_maker/directpins/promicro board had "bootloader": "atmel-dfu" for some reason; this broke qmk flash for people who actually tried to use that code on a Pro Micro. Set "development_board": "promicro" instead, so that the caterina bootloader and other settings appropriate for a Pro Micro would be used.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • qmk flash -kb ez_maker/directpins/promicro -km default did not work with a Pro Micro board due to the bootloader mismatch.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Setting the bootloader for something with `promicro` in the name to
`atmel-dfu` was really confusing.
@zvecr zvecr merged commit ccb37b1 into qmk:master Apr 29, 2023
@sigprof sigprof deleted the ez_maker-directpins-promicro-bootloader branch April 29, 2023 19:31
struckmb pushed a commit to struckmb/qmk_firmware that referenced this pull request May 1, 2023
Setting the bootloader for something with `promicro` in the name to
`atmel-dfu` was really confusing.
rodrigob pushed a commit to rodrigob/qmk_firmware that referenced this pull request May 2, 2023
Setting the bootloader for something with `promicro` in the name to
`atmel-dfu` was really confusing.
barrettclark added a commit to barrettclark/qmk_firmware that referenced this pull request May 4, 2023
* upstream/master: (46 commits)
  [Keyboard] Add 1upkeyboards pi50 (qmk#20242)
  `sofle/via` encoder map & doc handedness update (qmk#20630)
  [Keyboard] add phantagom/baragon marcopad (qmk#20543)
  [Keyboard] add phantagom/varan rgb numpad (qmk#20587)
  [Keymap] Small changes to fix failing karn keyboard build (qmk#20618)
  Repair Spleeb i2c config and chrishoage keymap (qmk#20644)
  Adding my keymap (qmk#20345)
  Add additional options for Drag Scroll config (qmk#20523)
  Added Velvet Hotswap and Solder PCBs (qmk#20510)
  [Keyboard] Add the Aster Ergo PCB (qmk#20513)
  vertex/angle65 - Implement RGBlight (qmk#20514)
  [Keymap update] Keymap & docs update (qmk#20298)
  Fix MATRIX_HAS_GHOST when MATRIX_COL > 16 (qmk#20093)
  ez_maker/directpins/promicro: Fix bootloader mismatch (qmk#20627)
  Fix up positioning of keys for Keychron Q10/V10 and Q6/V6 (qmk#20582)
  [Keymap] Add johnstegeman iris colemak keymap (qmk#20575)
  [Keyboard] Add Manibus VIA support (qmk#20497)
  Add KBDCraft Adam64 Lego board (qmk#20503)
  Update code example to match description (qmk#20528)
  NK Plus (qmk#20392)
  ...
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Setting the bootloader for something with `promicro` in the name to
`atmel-dfu` was really confusing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants