Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keymap][user] user dvorak_42_key ergodox_ez and crkbd keymaps #19154

Merged
merged 172 commits into from
Dec 12, 2022
Merged

[Keymap][user] user dvorak_42_key ergodox_ez and crkbd keymaps #19154

merged 172 commits into from
Dec 12, 2022

Conversation

luc-vocab
Copy link
Contributor

Description

Add user dvorak_42_key in userspace. add crkbd keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

luc wastiaux added 28 commits November 28, 2022 14:01
experimental layout for crkbd
336166d
remove some keys
166d09c
add back terminal / vscode shortcuts
8db4861
add caps word support
8a2731d
one shot modifiers on keynav layout
957c220
remove shift/ctrl frome base layer
8ca7a94
added shortcuts layer
ae7cf45
add delete/ctl+delete on keynav layer
670aa06
move all shortcuts to shortcuts layer
7ef2ce2
cleanup base layer
6e9bffd
add ctrl+x on shell layer
67ea4e0
added ctrl+n on keynav layer
1b982eb
better way of entering keysel, delete keys are on the right
4e8695d
remove tap dance
f2c235b
ctrl+delete on the left side
7085b34
cleanup keysel row
f9c6f3e
map ctrl+l on shell layer, cleanups
0ad34df
screen copy mode / paste on screen layer
ac3f61d
remove screen_nav layer
621c85a
cleanup
689ea4f
backspace on main layer
93a5768
add ctrl+f
e88971c
move some keys in combined to the right
bf05b6f
move symbols to left-side keys
e23b439
introduce IOS base layer and ios browser control
cdf133c
additional ios browser shortcuts
e101a0e
app switcher shortcut on iOS
763f0e2
keynav/keysel layers for IOS
51a1804
@fauxpark
Copy link
Member

fauxpark commented Dec 5, 2022

You can move your keymap folder under the rev1 keymaps folder (create it if it doesn't exist).

@luc-vocab
Copy link
Contributor Author

@drashna thank you for your time. i've implemented your changes and i've moved the keymap to keyboards/crkbd/rev1/keymaps/dvorak_42_key. Does this change now meet the pre-requisite to be merged ?

@luc-vocab
Copy link
Contributor Author

Hi, what is needed to merge this ?

fauxpark
fauxpark requested changes Dec 7, 2022
View reviewed changes
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
users/dvorak_42_key/dvorak_42_key.c Outdated Show resolved Hide resolved
luc-vocab and others added 11 commits December 7, 2022 08:25
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
db7298d 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
52282eb 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
5163f85 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
9eab0ff 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
ef9eed6 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
d74fee5 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
59e5597 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
0aa350f 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
5fbfcdf 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
bcd87a5 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab @fauxpark
Update users/dvorak_42_key/dvorak_42_key.c
5ae15fa 
Co-authored-by: Ryan <fauxpark@gmail.com>
@luc-vocab
Copy link
Contributor Author

@drashna can this change be merged ? I believe i've implemented all of the requested changes.

@luc-vocab
Copy link
Contributor Author

Hi, can this be merged ? Please let me know. Thank you.

@drashna drashna merged commit bf2ed01 into qmk:master Dec 12, 2022
@luc-vocab
Copy link
Contributor Author

Thank you !

crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@luc-vocab @drashna
@fauxpark @crembz
[Keymap] user dvorak_42_key ergodox_ez and crkbd keymaps (qmk#19154)
bec19da 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: luc wastiaux <luc.wastiaux@airpost.net>
Co-authored-by: Luc W <lucw@airpost.net>
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@luc-vocab @drashna @fauxpark
[Keymap] user dvorak_42_key ergodox_ez and crkbd keymaps (qmk#19154)
0f68299 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: luc wastiaux <luc.wastiaux@airpost.net>
Co-authored-by: Luc W <lucw@airpost.net>
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@luc-vocab @drashna
@fauxpark @omikronik
[Keymap] user dvorak_42_key ergodox_ez and crkbd keymaps (qmk#19154)
3ade0be 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: luc wastiaux <luc.wastiaux@airpost.net>
Co-authored-by: Luc W <lucw@airpost.net>
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@luc-vocab @drashna
@fauxpark @ideas32
[Keymap] user dvorak_42_key ergodox_ez and crkbd keymaps (qmk#19154)
416a2bd 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: luc wastiaux <luc.wastiaux@airpost.net>
Co-authored-by: Luc W <lucw@airpost.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 requested changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luc-vocab @waffle87 @fauxpark @drashna