Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move keyboard USB IDs and strings to data driven, pass 2: 0-9, A #17941

Merged
merged 2 commits into from
Aug 14, 2022
Merged

Move keyboard USB IDs and strings to data driven, pass 2: 0-9, A #17941

merged 2 commits into from
Aug 14, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Aug 7, 2022 •
edited
Loading

Description

These are the more complex boards to migrate, as they require some further modifications to avoid the issue of higher-level info.json values taking precedence over lower-level ones (eg. keyboard vs keyboard/rev1). For example 0_sixty has been tweaked to be comprised of 0_sixty/base (default) and 0_sixty/underglow.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 7, 2022 09:11
@fauxpark fauxpark mentioned this pull request Aug 8, 2022
Merged
14 tasks
@drashna drashna requested a review from a team August 11, 2022 19:43
@drashna drashna merged commit 3079691 into qmk:master Aug 14, 2022
@fauxpark fauxpark deleted the keyboards-usb-data-driven-2-0-9-a branch August 14, 2022 01:03
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@fauxpark @imhoffman
Move keyboard USB IDs and strings to data driven, pass 2: 0-9, A (qmk…
2e97b1c 
…#17941)
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@fauxpark @nolanseaton
Move keyboard USB IDs and strings to data driven, pass 2: 0-9, A (qmk…
42acfa9 
…#17941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @keyboard-magpie