Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old submodules if present #17930

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Remove old submodules if present #17930

merged 2 commits into from
Aug 13, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Aug 6, 2022

Description

Fixes up submodules when calling make git-submodule, as well as when running size regression checks.

Also adds make git-submodules because I always type the wrong one.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team August 6, 2022 11:51
@github-actions github-actions bot added the core label Aug 6, 2022
@noroadsleft
Copy link
Member

Also adds make git-submodules because I always type the wrong one.

❤️

@drashna drashna requested a review from a team August 8, 2022 23:25
keyboard-magpie
keyboard-magpie approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and the phony for submodule(s) is awesome

@tzarc tzarc merged commit dccb8ff into qmk:master Aug 13, 2022
@tzarc tzarc deleted the size-regression-submodules branch August 13, 2022 13:23
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@tzarc @imhoffman
Remove old submodules if present (qmk#17930)
6a014f5
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@tzarc @nolanseaton
Remove old submodules if present (qmk#17930)
71fb106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzarc @noroadsleft @drashna @keyboard-magpie