FJLabs Solanis Refactor #17686
Merged
FJLabs Solanis Refactor #17686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the matrix position identifier for the right half of Split Backspace to the number row.
github-actions
bot
added
the
via
fauxpark
approved these changes
Jul 15, 2022
WonderBeat
pushed a commit
to post-engineering/qmk_firmware
that referenced
this pull request
Jul 16, 2022
* 'master' of github.com:qmk/qmk_firmware: (179 commits) [Keymap] Crkbd/thunderbird2086 (qmk#16973) Suavity Ehan Refactor (qmk#17694) feat(keebwerk): added VIA support keymap for keebwerk nano slider (qmk#16761) FJLabs Solanis Refactor (qmk#17686) [Keyboard] add ProjectCain Relic (qmk#15577) [Keyboard] eHan Keyboard (qmk#15861) Move ins, home and pgup keys to the left (qmk#17690) [Keymap] emp keymap for keebio/iris (qmk#16858) Ignore kbfirmware exports (qmk#17687) [Keyboard] Added TutelPad keyboard (qmk#16975) [Keyboard] Add Chocofly v1 (qmk#17289) KB16-01: correct QMK Configurator key sequence (qmk#17670) Nayeon Community Layout support (qmk#17665) [Keyboard] Fix Tractyl Manuform 4x6 json (qmk#17681) [Keyboard] Readme file correction (qmk#17674) KPrepublic BM80v2 ISO Refactor (qmk#17660) [Keyboard] MechWild BB Steno (qmk#17163) [Keyboard] Modelm101 teensy2 (qmk#16805) Ducky One 2 SF touch-up (qmk#17672) Gentoo & Gentoo Hotswap: correct Configurator key sequence errors (qmk#17668) ...
smocky
pushed a commit
to smocky/qmk_firmware
that referenced
this pull request
Jul 22, 2022
* solanis.h: add matrix diagram * refactor keymaps: apply grid alignment * refactor LAYOUT_all macro Moves the matrix position identifier for the right half of Split Backspace to the number row.
schattenbrot
pushed a commit
to schattenbrot/qmk_firmware
that referenced
this pull request
Aug 2, 2022
* solanis.h: add matrix diagram * refactor keymaps: apply grid alignment * refactor LAYOUT_all macro Moves the matrix position identifier for the right half of Split Backspace to the number row.
imhoffman
pushed a commit
to imhoffman/qmk_firmware
that referenced
this pull request
Aug 20, 2022
* solanis.h: add matrix diagram * refactor keymaps: apply grid alignment * refactor LAYOUT_all macro Moves the matrix position identifier for the right half of Split Backspace to the number row.
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
* solanis.h: add matrix diagram * refactor keymaps: apply grid alignment * refactor LAYOUT_all macro Moves the matrix position identifier for the right half of Split Backspace to the number row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Physically arranges the layout macro to resemble the assembled board.
With this PR applied, the keycode for the right half of a split Backspace is directly after the left half, instead of after the Enter keycode.
Compilation results before and after are the same:
cc @mrnoisytiger (keyboard maintainer)
Types of Changes
Checklist